Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPMI Serial definitions #6454

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gtossk2
Copy link

@gtossk2 gtossk2 commented Nov 21, 2024

Description

Add definitions for IPMI Serial and it can be used in ManageabilityPkg.

How This Was Tested

Tested in tianocore/edk2-platforms#240

Integration Instructions

N/A

Copy link
Contributor

@abdattar abdattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looks good.

MdePkg/Include/IndustryStandard/IpmiSerial.h Outdated Show resolved Hide resolved
Copy link
Member

@changab changab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gtossk2, I will merge this change on next Mon as we are now in the code freeze period.

@changab
Copy link
Member

changab commented Nov 22, 2024

@gtossk2 The quiet period has now ended, however, we still need another approval.

This change adds new PCDs for IPMI Serial.

Specification reference:
https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html

Signed-off-by: John Chung <john.chung@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants