Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOOP-4735 CGM Event Store #93

Merged
merged 55 commits into from
Sep 27, 2023
Merged

LOOP-4735 CGM Event Store #93

merged 55 commits into from
Sep 27, 2023

Conversation

ps2
Copy link
Contributor

@ps2 ps2 commented Sep 26, 2023

https://tidepool.atlassian.net/browse/LOOP-4735

Implement placeholder handler for CGM Events.

Also includes some translation updates from DIY.

ps2 and others added 30 commits January 20, 2023 16:28
Updated translations from Lokalise on Thu Feb  9 13:30:18 CST 2023
…-service

Remote PR Set #2: Introduce RemoteCommands
…-command-service

Revert "Remote PR Set #2: Introduce RemoteCommands"
Upload automation status for temp and normal basals.
Updated translations from Lokalise on Sat Mar 18 15:11:44 CDT 2023
Basal rate fixes, and tests passing.
ps2 and others added 20 commits April 5, 2023 17:55
* Updating to new TidepoolKit with keycloak based auth

* SettingsView using TidepoolService as ObservedObject

* Tweak logo size

* Fix issues with state restoration and re-logging in. Add alert when session loss is detected

* Improve DataSetId caching

* Do not allow environment switching when logged in

* Tweak wording
Conflicts:
	TidepoolServiceKit/IdentifiableDatum.swift
	TidepoolServiceKit/IdentifiableHKDatum.swift
	TidepoolServiceKit/TidepoolService.swift
	TidepoolServiceKitTests/TidepoolServiceTests.swift
	TidepoolServiceKitUI/SettingsView.swift
	TidepoolServiceKitUI/TidepoolService+UI.swift
* Remote handling rearchitecture

* Rename method

* Update names

* Remove Remote 2.0 parts
Updated translations from Lokalise on Sat Aug 19 15:10:08 CDT 2023
@ps2 ps2 requested review from nhamming, Camji55 and ArwainK September 26, 2023 15:33
Comment on lines +620 to +623
public func uploadCgmEventData(_ stored: [LoopKit.PersistedCgmEvent], completion: @escaping (Result<Bool, Error>) -> Void) {
// TODO: Upload sensor/transmitter changes
completion(.success(false))
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this intentional?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess it is. approving.

@nhamming nhamming self-requested a review September 27, 2023 08:12
Copy link
Contributor

@nhamming nhamming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ps2 ps2 merged commit 6555a71 into dev Sep 27, 2023
@ps2 ps2 deleted the ps2/LOOP-4735/cgm-event-store branch September 27, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants