-
-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix models length issue #1420
base: master
Are you sure you want to change the base?
fix models length issue #1420
Conversation
@cb1kenobi any idea why the tests are failing? They work fine locally
not sure how I can fix that. |
That's not a CLI error, it's an Alloy error: Line 47 in be399c8
Alloy is reading the config to get the selected SDK, but that's obsolete in CLI v7. Alloy should get the SDK version from the |
ohhhh ok, I didn't check for the error message in the project 🤦 Let me fix that! Thanks for the hint |
merge #1421 first. There I'm fixing build issues and some other Alloy code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Approving, but waiting for PR #1421 to land.
A bit difficult to test but in my case I had
which produced:
and models was
null
for me which caused an error "length of undefined".Instead of crashing it should just use
len = 0
for this.merge #1421 first. There I'm fixing build issues and some other Alloy code