-
-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove old code, fix sdk version, update action #1421
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this PR! Needs a couple of small changes.
What's up with the removal of Ti.UI.iPhone.NavigationGroup.js
? Is this a breaking change?
DEPRECATED_VERSION = '3.1.3' |
The tests fail on WSL for the same reason the CI checks fail below. For example:
Not sure what's causing that. Isn't the Android and iOS stuff mocked? |
@cb1kenobi did you had some time to look at this? I can put in the fixed again so the test will succeed |
ti config
selected.sdk check (not used anymore)