Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove checks on newdata typo in glmnet-related functions #877

Closed
hfrick opened this issue Feb 22, 2023 · 1 comment · Fixed by #879
Closed

Remove checks on newdata typo in glmnet-related functions #877

hfrick opened this issue Feb 22, 2023 · 1 comment · Fixed by #879
Labels
upkeep maintenance, infrastructure, and similar

Comments

@hfrick
Copy link
Member

hfrick commented Feb 22, 2023

The various glmnet-related predict methods include a check if the user may have used newdata instead of new_data. This is not glmnet-specific and gets checked inside of predict.model_fit() via check_pred_type_dots() so we can remove it here.
@hfrick hfrick mentioned this issue Feb 22, 2023
Open
@hfrick hfrick added the upkeep maintenance, infrastructure, and similar label Feb 22, 2023
@hfrick hfrick mentioned this issue Feb 22, 2023
Merged
@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove check on newdata typo in glmnet functions tidymodels/parsnip
1 participant
@hfrick