remove check on newdata typo in glmnet functions #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`predict.model_fit()` checks this via `check_pred_type_dots()`
topepo
approved these changes
Feb 23, 2023
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #877
predict_glmnet()callspredict.model_fit()which checks this viacheck_pred_type_dots()so we don't need it inpredict_glmnet().The
predict_<type>()methods don't run this check. I think generally users are supposed to usepredict(type = <type>)rather thanpredict_<type>()but thepredict_<type>()functions are exported. If we think this check is important to have also when directly callingpredict_<type>(), I'd suggest we add it to the method formodel_fitobjects but since it's not glmnet-specific, I have removed it here.multi_predict()does not have a centralmodel_fitmethod (because it doesn't apply to all models) so I have left the check in the glmnet-specific method.The tests for glmnet engines live in extratests, those checks pass locally and will be run on CI once this is merged.