-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slice()
unnecessarily evaluates ...
twice for each group
#377
Labels
Comments
eutwt
changed the title
performance:
Jul 19, 2022
slice()
unnecessarily evaluates ...
twice for each groupslice()
unnecessarily evaluates ...
twice for each group
Oops. I missed that, thanks to Rdatatable/data.table#4353, this can be fixed more easily by using |
I sort of still like the idea of doing this one 🤷♂️
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
slice()
could be made faster when the arguments in...
are expensive to compute by evaluating...
only once per group. In the example below where the argument to slice takes one second to compute and there are two groups, the code takes ~4 seconds to run instead of ~2.Created on 2022-07-19 by the reprex package (v2.0.1)
The text was updated successfully, but these errors were encountered: