Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtplyr release? #407

Closed
hadley opened this issue Feb 7, 2023 · 10 comments
Closed

dtplyr release? #407

hadley opened this issue Feb 7, 2023 · 10 comments

Comments

@hadley
Copy link
Member

hadley commented Feb 7, 2023

Any concern with me doing a dtplyr release? (It's broken by dplyr 1.1.0)

Should this be a patch version or a minor version?

@markfairbanks
Copy link
Collaborator

I think it's ready for a minor version. There are a bunch of new functions/bug fixes as well as some performance improvements for select() and arrange().

Only possible negative is .by isn't implemented yet? I don't think that's necessarily a blocker though.

@hadley
Copy link
Member Author

hadley commented Feb 7, 2023

If someone could implement .by soon (maybe in the next week?) I think we could hold off; otherwise I think it's fine to include that in the next minor release.

@markfairbanks
Copy link
Collaborator

If someone could implement .by soon (maybe in the next week?) I think we could hold off;

Yeah that should be doable, I'll take a look.

@hadley
Copy link
Member Author

hadley commented Feb 8, 2023

@markfairbanks also would mind giving me a list of what you think the biggest new features are? (i.e. what are the things that I should highlight in the blog post?)

@markfairbanks
Copy link
Collaborator

Yep, will do. Also FYI I took an initial pass at .by and I'll have a PR by Friday.

@hadley
Copy link
Member Author

hadley commented Feb 8, 2023

Awesome, thanks!

@markfairbanks
Copy link
Collaborator

Here's the list. I grabbed this from the reorganized NEWS from #410. Not sure if all of these should be in the blog post but they're the most notable.

New features

Performance improvements

Minor improvements and bug fixes

@hadley
Copy link
Member Author

hadley commented Feb 9, 2023

Thanks!

I'd suggest moving the last point to a new "breaking changes" heading at the top of the news for this release. I don't think it will affect many people, but it's good to advertise prominently.

@markfairbanks
Copy link
Collaborator

Sounds good

@hadley
Copy link
Member Author

hadley commented Feb 14, 2023

Closing this issue and about to open an official release issue.

@hadley hadley closed this as completed Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants