Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement .by/by #410

Merged
merged 17 commits into from
Feb 13, 2023
Merged

Implement .by/by #410

merged 17 commits into from
Feb 13, 2023

Conversation

markfairbanks
Copy link
Collaborator

@markfairbanks markfairbanks commented Feb 9, 2023 •
edited
Loading

Closes #399

Overview of changes

  • Internal helper compute_by() was implemented (modeled after dplyr/dbplyr versions)
  • A by arg was added to the step_subset_i()/step_subset_j() internal helpers.
    These are passed the result of compute_by() by filter()/mutate()/summarize()/slice_*().

@markfairbanks markfairbanks marked this pull request as draft February 9, 2023 01:26
@markfairbanks markfairbanks marked this pull request as ready for review February 9, 2023 20:13
@markfairbanks markfairbanks mentioned this pull request Feb 9, 2023
Closed
hadley
hadley reviewed Feb 11, 2023
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

R/by.R Outdated Show resolved Hide resolved
DESCRIPTION Outdated Show resolved Hide resolved
R/by.R Outdated Show resolved Hide resolved
R/step-mutate.R Outdated Show resolved Hide resolved
R/step-subset-slice.R Show resolved Hide resolved
R/step-subset-slice.R Outdated Show resolved Hide resolved
@eutwt
Copy link
Collaborator

eutwt commented Feb 12, 2023

Sorry, won't have time to review this. Things are pretty hectic right now where I'm working

@markfairbanks
Copy link
Collaborator Author

No worries, thanks @eutwt

@markfairbanks markfairbanks requested review from hadley and removed request for eutwt February 13, 2023 14:51
hadley
hadley approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! If you want to merge this, I'll start the release process tomorrow morning.

@markfairbanks markfairbanks merged commit ef1b797 into main Feb 13, 2023
@markfairbanks markfairbanks deleted the by-arg branch February 13, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement .by
3 participants
@markfairbanks @eutwt @hadley