Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use intermediate variable in slice() #378

Merged
merged 4 commits into from
Jul 25, 2022
Merged

Use intermediate variable in slice() #378

merged 4 commits into from
Jul 25, 2022

Conversation

markfairbanks
Copy link
Collaborator

See #377

@markfairbanks
Copy link
Collaborator Author

Good for review.

Also does anyone have an idea what this check failure is caused by? 🤷‍♂️

@eutwt
Copy link
Collaborator

eutwt commented Jul 25, 2022

My guess is that since the output of expr({...}) has a "srcref" attribute, covr treats it as a separate source file to check. You can either use call2 instead (whose output doesn't have that attribute) or use i <- rlang::zap_srcref(i) after to get rid of the attribute.

@markfairbanks markfairbanks merged commit be52878 into main Jul 25, 2022
@markfairbanks markfairbanks deleted the slice-temp-rows branch July 25, 2022 14:17
@markfairbanks
Copy link
Collaborator Author

Thanks for figuring out that test @eutwt 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants