-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: Partial scales #5444
Draft
teunbrand
wants to merge
17
commits into
tidyverse:main
Choose a base branch
from
teunbrand:partial_scales
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
POC: Partial scales #5444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on #4271, aiming to fix #4269.
Briefly, it is convenient to set some scale parameter, without committing to a full scale yet.
This PR introduces a
<Scale>
subclass,<ScalePartial>
, that carries around parameters. These get merged with full scales, as soon as they're added by users, or added by default.The end goal beyond this PR is to provide convenient scales to implement #2691, so that one can set a default
palette
orexpand
in the theme without locking in other parameters.This PR is still a work in progress:
Some details:
ScalesList$add()
method is responsible for merge-order of partial/full scales.<Scale>
objects get afields
member, which declares parameters that can be set by the user.<Scale>
objects get aupdate_params()
method that merges in the partial scales.<Scale>
objects get avalidate()
method to double check that the partial scale isn't feeding illegal parameters.trans
parameter, thelimits
are backtransformed to apply the newtrans
parameter properly.Some examples:
Created on 2023-09-28 with reprex v2.0.2
There are still come rough patches in this PR, in particular when it comes to error messages.
In the case below, I think it is appropriate to report the full scale in the error message:
However, when there is no full scale, the partial scales gets resolved during whatever build stage feels the need to add missing or default scales. This can lead to some awkward error messages, i.e. below there is no issue with
geom_point()
but it is mentioned first.Created on 2023-09-28 with reprex v2.0.2