-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scale parameters #6196
Open
teunbrand
wants to merge
14
commits into
tidyverse:main
Choose a base branch
from
teunbrand:scale_experiment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Scale parameters #6196
+296
−158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'main' into scale_experiment # Conflicts: # R/scale-.R
thomasp85
reviewed
Jan 27, 2025
R/scale-.R
Outdated
Comment on lines
551
to
556
if (inherits(scale, "ScaleContinuous")) { | ||
args <- fn_fmls_names(continuous_scale) | ||
} else if (inherits(scale, "ScaleDiscrete")) { | ||
args <- fn_fmls_names(discrete_scale) | ||
} else if (inherits(scale, "ScaleBinned")) { | ||
args <- fn_fmls_names(binned_scale) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice if this information was somehow incorporated into the class, rather than having to check an "unlinked" constructor function
Merge branch 'main' into scale_experiment # Conflicts: # R/scale-.R # R/scales-.R # tests/testthat/test-scales.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on #4271 and #5444, aiming to fix #4269.
Like before, it aims to provide the convenience of setting some scale parameters, without comitting to a full scale yet.
Unlike #5444, this PR is closer to Claus' approach in #4271.
This PR the
scale_params()
function that populates a newScalesList$params
field. When a new scale is added, it will get updated with the parameters in that field. The update mechanism required the most attention. Every<Scale>
class now has aScale$new()
method that takes on most of the work thatcontinuous_scale()
,discrete_scale()
,binned_scale()
constructors were doing before. TheScale$update()
method is a thin wrapper around this and should resolve gnarly situations (e.g. limit transformation).In the demo below we can note:
The update mechanism should also recognise invalid updates:
Created on 2024-11-22 with reprex v2.1.1