Skip to content

Unterminated comment now errors #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 27, 2021
Merged

Unterminated comment now errors #227

merged 5 commits into from
Sep 27, 2021

Conversation

@gaborcsardi
Copy link
Member

@gaborcsardi gaborcsardi commented Sep 25, 2021

This is on top of #226.

Closes #224.

@gaborcsardi
Update GHA platforms and R versions
9d88032 
* Use R versions up to R 4.1.
* Remove old R versions, 3.2, 3.3, they
  are not supported any more.
* Update Ubuntu to 18.04.
@gaborcsardi
Make untermiated quotes error
c9f9cf9 
Closes #219.
@gaborcsardi
Unterminated comments error now
1fbb9a3 
Instead of generating an empty string.

Closes #224.
@jimhester
Copy link
Collaborator

jimhester commented Sep 27, 2021

Thanks!

@jimhester jimhester merged commit 775916b into master Sep 27, 2021
@gaborcsardi gaborcsardi mentioned this pull request Oct 4, 2021
Closed
@jennybc jennybc deleted the fix/unterminated-comment branch December 4, 2021 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimhester jimhester Awaiting requested review from jimhester

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Comment inside {} suppresses output

3 participants

@gaborcsardi @jimhester