Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: imu monitor #333

Merged
merged 12 commits into from
Apr 14, 2023
Merged

feat: imu monitor #333

merged 12 commits into from
Apr 14, 2023

Conversation

0x126
Copy link

@0x126 0x126 commented Mar 22, 2023

Description

  • Add new module
    • This module compares the yaw rate obtained from the IMU with that obtained from the vehicle and outputs ERROR diagnostics if the difference is large

Related links

TIER IV INTERNAL LINK

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@0x126 0x126 requested review from TomohitoAndo and mkuri March 22, 2023 14:49
@github-actions github-actions bot added documentation Improvements or additions to documentation system labels Mar 22, 2023
@0x126 0x126 changed the title Feat/imu monitor feat: imu monitor Mar 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.6.1@2e6f61e). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@              Coverage Diff               @@
##             beta/v0.6.1     #333   +/-   ##
==============================================
  Coverage               ?   10.58%           
==============================================
  Files                  ?     1249           
  Lines                  ?    90061           
  Branches               ?    20801           
==============================================
  Hits                   ?     9532           
  Misses                 ?    70442           
  Partials               ?    10087           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.56% <0.00%> (?) Carriedforward from c47c29f

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@0x126 0x126 marked this pull request as ready for review March 26, 2023 06:22
@0x126 0x126 force-pushed the feat/imu-monitor branch from c5e0e93 to c47c29f Compare March 26, 2023 06:22
@TomohitoAndo
Copy link

@0x126
Is the JIRA ticket in Related links is correct? It looks like the ticket for collision checker.
TIER IV INTERNAL LINK

@0x126
Copy link
Author

0x126 commented Apr 13, 2023

sorry, I fixed.

@TomohitoAndo
Copy link

@0x126
Isn't this added to diagnostic aggregator?

@0x126
Copy link
Author

0x126 commented Apr 13, 2023

Isn't this added to diagnostic aggregator?

I'll make another PR.

@TomohitoAndo TomohitoAndo self-requested a review April 14, 2023 05:27
@0x126 0x126 merged commit 73f0d06 into beta/v0.6.1 Apr 14, 2023
@0x126 0x126 deleted the feat/imu-monitor branch April 14, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants