Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync upstream #42

Merged
merged 33 commits into from
May 8, 2022
Merged

chore: sync upstream #42

merged 33 commits into from
May 8, 2022

Conversation

tier4-autoware-public-bot[bot]
Copy link

@tier4-autoware-public-bot tier4-autoware-public-bot bot commented Apr 27, 2022

Features

Bug Fixes

Documentation

Styles

Code Refactoring

Performance Improvements

Chores

Sharrrrk and others added 5 commits April 26, 2022 18:44
…eriod parameter (#763)

* perf(trajectory_follower_nodes): change longitudinal control to use period parameter

Signed-off-by: Shark Liu <shark.liu@autocore.ai>

* perf(trajectory_follower_nodes): remove duplicate ros parameters in 'control.launch.py'

Signed-off-by: Shark Liu <shark.liu@autocore.ai>

* doc(trajectory_follower_nodes): update design doc according to code update

Signed-off-by: Shark Liu <shark.liu@autocore.ai>

* ci(pre-commit): autofix

Co-authored-by: Shark Liu <shark.liu@autocore.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
…769)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
* feat(default_ad_api): add interface version

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(default_ad_api): add http server

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(default_ad_api): add message readme

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(default_ad_api): modify message readme

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(default_ad_api): fix message type

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(default_ad_api): fix message type

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(default_ad_api): remove unused message

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(component_interface_utils): use full path

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(component_interface_utils): rename package

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(autoware_ad_api_msgs): remove unused message

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(component_interface_utils): add readme and comments

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(default_ad_api): fix api name

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Update common/autoware_ad_api_msgs/README.md

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* add test

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix server name

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add comment

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix typo

* rename version api

* Update system/default_ad_api/package.xml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Update common/component_interface_utils/include/component_interface_utils/rclcpp/create_interface.hpp

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Update system/default_ad_api/launch/default_ad_api.launch.py

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Fix for renaming web server script

* Fix test script for readability

* Fix test script for readability

* Add comment

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #42 (4dba2ed) into tier4/main (cdbff23) will increase coverage by 5.14%.
The diff coverage is 5.00%.

@@              Coverage Diff               @@
##           tier4/main      #42      +/-   ##
==============================================
+ Coverage        5.30%   10.44%   +5.14%     
==============================================
  Files              92      753     +661     
  Lines            6917    52625   +45708     
  Branches          663     6843    +6180     
==============================================
+ Hits              367     5498    +5131     
- Misses           6298    42622   +36324     
- Partials          252     4505    +4253     
Flag Coverage Δ
differential 10.44% <5.00%> (+5.14%) ⬆️
Impacted Files Coverage Δ
...to_common/include/helper_functions/byte_reader.hpp 66.66% <ø> (ø)
.../include/helper_functions/mahalanobis_distance.hpp 100.00% <ø> (ø)
...auto_common/include/helper_functions/type_name.hpp 66.66% <ø> (ø)
common/autoware_auto_common/test/gtest_main.cpp 100.00% <ø> (ø)
...mon/autoware_auto_common/test/test_angle_utils.cpp 28.57% <ø> (ø)
...mon/autoware_auto_common/test/test_byte_reader.cpp 66.66% <ø> (ø)
...are_auto_common/test/test_mahalanobis_distance.cpp 50.00% <ø> (ø)
...e_auto_common/test/test_message_field_adapters.cpp 45.83% <ø> (ø)
.../autoware_auto_common/test/test_template_utils.cpp 100.00% <ø> (ø)
...ommon/autoware_auto_common/test/test_type_name.cpp 40.00% <ø> (ø)
... and 750 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdbff23...4dba2ed. Read the comment docs.

taikitanaka3 and others added 23 commits April 27, 2022 09:48
…#764)

* chore(behavior_velocity): add system delay parameter and minor update

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* doc(behavior_velocity): add system delay discription

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
…818)

this is happens whenever intersection is involved.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…#728)

* fix(behavior_path_planner): fix the condition of turn signal lighting

Signed-off-by: k-obitsu <koichi.obitsu@tier4.jp>

* fix(behavior_path_planner): fix the condition of turn signal lighting

Signed-off-by: k-obitsu <koichi.obitsu@tier4.jp>

* ci(pre-commit): autofix

* Update planning/behavior_path_planner/src/turn_signal_decider.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
…807)

* feat(obstacle_avoidance_planner): parameterize bounds search widths

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update bounds search widths

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update tier4_planning_launch

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Added parameter description of README.md

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
* feat(map_based_prediction): upgrade yaw difference tolerance

Signed-off-by: yutaka <purewater0901@gmail.com>

* Update perception/map_based_prediction/src/map_based_prediction_node.cpp

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix format

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
* fix(pointcloud_preprocessor): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(ground_segmentation): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(compare_map_segmentation): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(occupancy_grid_map_outlier_filter): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(euclidean_cluster): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(detection_by_tracker): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* fix(component_interface_utils): add USE_DEPRECATED_TO_YAML

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix(lidar_apollo_instance_segmentation): add USE_TF2_GEOMETRY_MSGS_DEPRECATED_HEADER

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add rclcpp_components to package.xml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
* feat(behavior_path_planner): debug message for avoidance

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix: make_shared for the pointers

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* chore: pre-commit

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix: remove related DEBUG_PRINT

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* chore: naming, add debug to the variable name

This is so that people can infer mutable to debug, therefore reducing the amount
of time for debugging other things

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix: object id is written as string instead of uint8x16

Also fix getUuidStr function to reflect the actual hex value.
the function is moved to avoidance_util as it better served as helper function.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* chore: fix spelling

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix: display all 32 uuid characters

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* chore: remove unnecessary header

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* feat: support more debug message

Note: need further refactoring, due to multiple similar code, plus duplicate printing.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix mutiplication by introducing global variables

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* header stamp to get the clock

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix: renaming the type to show clearer intent of the type

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
* Activate by location

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Fix markdown

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
)

this is due to the assignment to pointer without guards in the function

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* feat(behavior_path): use multi thread

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix mutex

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix double unlock of mutex

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix multi access to planner_data_

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* rename mutex

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* apply mutex to bt_manager_

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…using raymarchig (#527)

* Create pointcloud by raycasting from vehicle

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* [after-review] Use vector of ObjectInfo

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* [after-review] Implemented by strategy pattern

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* [after-review] split files

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Use pcl raytracing

Tmp

Tmp

Tmp

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Add signed distance function lib

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Use sdf library

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Remove no longer used functions

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Refactor

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Simplify getPoint

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Raytracing considering inter object relation

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Add random noise

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Default is object centric

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Return if no objects are detected

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Change definition of tf_global_to_local (same as other autoware codes)

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Remove create method

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Reaname: VehicleCentric -> EgoCentric

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Refactor a bit

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Tune parameter

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Fix: Even if selected_idices is zero, pointclouds must be published

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Fix launch file

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Fix typo

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Fix: create merged pointcloud when no idx is selected

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Use ray-maching by default

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>
* fix(obstacle_stop_planner): modify undefined symbol

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* fix(behavior_velocity_planner): avoid zero division in pcl

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* use empty()

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
* docs(autoware_auto_geometry): fix link

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* Fix spelling

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
…ROS1 to ROS2 (#458)

* feat(lanelet2_map_preprocessor): port lanelet2_map_preprocessor from ROS1 to ROS2

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kenji-miyake and others added 5 commits May 4, 2022 10:44
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
* remove autoware_auto_cmake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add build_depend of autoware_cmake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* use autoware_cmake in CMakeLists.txt

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix bugs

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix cmake lint errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@wep21 wep21 self-requested a review May 8, 2022 05:36
@tier4-autoware-public-bot tier4-autoware-public-bot bot merged commit 6174d32 into tier4/main May 8, 2022
@tier4-autoware-public-bot tier4-autoware-public-bot bot deleted the sync-upstream branch May 8, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.