Use rustup provided clippy. #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2018
|
PTAL @overvenus |
|
@overvenus please follow the rule to give LGTM or approve it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also see: https://internals.rust-lang.org/t/clippy-is-available-as-a-rustup-component/7967
Move the clippy we use from being installed by
cargoto being installed byrustup. If you find strange problems with clippy after they are merged you will need to do:cargo uninstall clippy && cargo uninstall clippy-lints && rustup self updateThis is because the old versions of rustup don't know that clippy is managed, so they give errors like
subcommand clippy does not exist.Reasons for doing this:
Currently the clippy version must be managed separate from the Rust nightly. Using Rustup will allow each of our projects to depend on their own clippy versions and help avoid some toolchain related problems.
The PRs: