Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Use rustup provided clippy. #95

Merged
merged 1 commit into from
Jul 23, 2018
Merged

travis: Use rustup provided clippy. #95

merged 1 commit into from
Jul 23, 2018

Conversation

Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Jul 18, 2018

Also see: https://internals.rust-lang.org/t/clippy-is-available-as-a-rustup-component/7967

Move the clippy we use from being installed by cargo to being installed by rustup. If you find strange problems with clippy after they are merged you will need to do: cargo uninstall clippy && cargo uninstall clippy-lints && rustup self update

This is because the old versions of rustup don't know that clippy is managed, so they give errors like subcommand clippy does not exist.

Reasons for doing this:

Currently the clippy version must be managed separate from the Rust nightly. Using Rustup will allow each of our projects to depend on their own clippy versions and help avoid some toolchain related problems.

The PRs:

@Hoverbear Hoverbear self-assigned this Jul 18, 2018
@Hoverbear Hoverbear added this to the 0.4.0 milestone Jul 18, 2018
@siddontang
Copy link
Contributor

LGTM

@breezewish
Copy link
Member

Would you also consider add a PR to rust-prometheus? :)

@Hoverbear
Copy link
Contributor Author

@breeswish Youre breeswish is my command. :)

@breezewish
Copy link
Member

LGTM

@Hoverbear Hoverbear merged commit 22f038e into master Jul 23, 2018
@Hoverbear Hoverbear deleted the use-rustup-clippy branch July 23, 2018 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants