-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support pre-generate bindings for aarch64 #430
Conversation
Thanks for your contribution. But I'm worry about the maintenance of the feature. On one hand, the bindings should be tested by CI to ensure the generated bindings actually work. On the other hand, because we don't have machines that are aarch64 based. It will be broken when we are trying to upgrade grpc c core. |
|
7c62542
to
16106e3
Compare
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
@BusyJay PTAL |
addons: | ||
apt: | ||
update: true | ||
packages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generating bindgen needs LLVM support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. It seems the default CI environment already install llvm tool chains. On the other hand, there are no llvm apt repo available on aarch64/linux, thus made it hard to install llvm tool chain on this platform, so just use the system default packages maybe a good idea currently.
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
@hunterlxt PTAL again~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
Signed-off-by: glorv <glorvs@163.com>
follow #356 this pr support pre generated binding for aarch64, so we can get rid of depending on newer version of clang.
Signed-off-by: glorv glorvs@163.com