Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support pre-generate bindings for aarch64 #430

Merged
merged 13 commits into from
Mar 5, 2020
+6,887 −16
Merged

support pre-generate bindings for aarch64 #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cd018d1
add pre generated binding for aarch64
glorv Feb 20, 2020
35abaea
add arch64 test config
glorv Feb 20, 2020
e1576df
change config
glorv Mar 3, 2020
61972e0
fix ci config
glorv Mar 3, 2020
8518641
update
glorv Mar 3, 2020
6a878d5
update new binding file
glorv Mar 4, 2020
74c375c
skip check tidy for aarch64
glorv Mar 4, 2020
fc78440
Merge branch 'master' into aarch-bindgen
glorv Mar 4, 2020
233e36a
remove duplicated task
glorv Mar 4, 2020
5fb5d32
add check git for aarch
glorv Mar 5, 2020
889dd44
update uname condation
glorv Mar 5, 2020
51d0433
fix syntax
glorv Mar 5, 2020
73989ac
skip lint&git check on aarch64 according to comment
glorv Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,21 @@ matrix:
rust: stable
osx_image: xcode10.2

addons:
apt:
update: true
sources:
- llvm-toolchain-xenial-7
packages:
- clang-tidy-7
- llvm-7-dev
- libclang-7-dev
- clang-7
- os: linux
arch: arm64
rust: stable
install:
- if ! which go 2>/dev/null; then
wget https://dl.google.com/go/go1.13.8.linux-arm64.tar.gz;
tar -xf go1.13.8.linux-arm64.tar.gz -C $HOME;
export PATH="$HOME/go/bin:$PATH";
export GO_ROOT=$HOME/go;
fi
addons:
apt:
update: true
packages:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generating bindgen needs LLVM support

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. It seems the default CI environment already install llvm tool chains. On the other hand, there are no llvm apt repo available on aarch64/linux, thus made it hard to install llvm tool chain on this platform, so just use the system default packages maybe a good idea currently.

- libunwind-dev

before_script:
- scripts/reset-submodule.cmd
Expand Down Expand Up @@ -98,7 +103,10 @@ script:
rustup component add rustfmt && cargo fmt --all -- --check;
scripts/generate-bindings.sh && git diff --exit-code HEAD;
fi
- if [[ $TRAVIS_OS_NAME == "linux" ]]; then scripts/lint-grpc-sys.sh && git diff-index --quiet HEAD; fi
# clang-tidy-7 is not available on aarch64, so just skip lint
- if [[ $TRAVIS_OS_NAME == "linux" ]] && [[ `uname -p` != "aarch64" ]]; then
scripts/lint-grpc-sys.sh && git diff-index --quiet HEAD;
fi
- if [[ $TRAVIS_RUST_VERSION == "stable" ]]; then rustup component add clippy && cargo clippy --all -- -D clippy::all && cargo clippy --all --no-default-features --features prost-codec -- -D clippy::all; fi
- cargo build --no-default-features
- cargo build --no-default-features --features protobuf-codec
Expand Down
Loading