Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/regions/replicated may return the wrong results #5095

Closed
rleungx opened this issue Jun 2, 2022 · 0 comments · Fixed by #5080
Closed

/regions/replicated may return the wrong results #5095

rleungx opened this issue Jun 2, 2022 · 0 comments · Fixed by #5080
Labels
affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@rleungx
Copy link
Member

rleungx commented Jun 2, 2022

Bug Report

Use /regions/replicated to query if the regions in the specified range are all replicated. But this API only checks the regions inside the waiting list which is not accurate and may return the wrong results. See

pd/server/api/region.go

Line 283 in fc55b44

for _, item := range rc.GetCoordinator().GetWaitingRegions() {

It is because the waiting list is shared by some checkers and saves 1000 regions at most. And in the recent modification, we only put the regions, which are filtered by the temporary store state, into it. Then, the result could be more misleading.
@rleungx rleungx added the type/bug The issue is confirmed as a bug. label Jun 2, 2022
@rleungx rleungx mentioned this issue Jun 2, 2022
Merged
@VelocityLight VelocityLight added affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-5.3 and removed affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. labels Jun 7, 2022
@rleungx rleungx added affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. severity/moderate labels Jun 7, 2022
ti-chi-bot pushed a commit that referenced this issue Jun 7, 2022
@rleungx
*: fix the wrong pending status (#5080)
e19dc71 
close #5095

Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jun 7, 2022
@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#5080
a40ae2a 
close tikv#5095

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Jun 7, 2022
Closed
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jun 7, 2022
@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#5080
6631e0b 
close tikv#5095

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jun 7, 2022
@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#5080
55eff94 
close tikv#5095

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Jun 7, 2022
Closed
Merged
@rleungx rleungx removed affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. labels Jun 15, 2022
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@rleungx @CabinfeverB
*: fix the wrong pending status (tikv#5080)
7680706 
close tikv#5095

Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot added a commit that referenced this issue Jul 18, 2022
@ti-chi-bot @rleungx
*: fix the wrong pending status (#5080) (#5115)
cf931ec 
ref #5080, close #5095

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
@nolouch nolouch mentioned this issue Aug 29, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: fix the wrong pending status rleungx/pd
2 participants
@VelocityLight @rleungx