*: fix the wrong pending status (#5080) #5112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close tikv#5095 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/cherry-pick-not-approved
release-note
VelocityLight
added
cherry-pick-approved
|
cc @rleungx |
It seems that it doesn't affect 5.3. Close it. |
VelocityLight
added
do-not-merge/cherry-pick-not-approved
cherry-pick-approved
VelocityLight
added
do-not-merge/cherry-pick-not-approved
and removed
cherry-pick-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #5080
Signed-off-by: Ryan Leung rleungx@gmail.com
What problem does this PR solve?
Issue Number: Close #5095.
What is changed and how does it work?
This PR adds a
pendingListin theruleCheckerto record the region that cannot be scheduled due to some long-term states. e.g., no enough stores, no enough space and etc. Once these regions can be scheduled or filtered by the temp state, they will be removed from thependingList.Check List
Tests
Related changes
Release note