Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch the resource group changes #5794

Closed
nolouch opened this issue Dec 19, 2022 · 1 comment · Fixed by #5830
Closed

Watch the resource group changes #5794

nolouch opened this issue Dec 19, 2022 · 1 comment · Fixed by #5830
Assignees
Labels
type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@nolouch
Copy link
Contributor

nolouch commented Dec 19, 2022

Feature Request

ref #5794
Provide a way let the client can watch the configuration changes, then TiKV/Storage can updates the priority settings.

Option

I prefer provide a common mechanism, that's client can watch different key or keyprfix in etcd, when it changes, the client can watch it. A basic implement in befor: #4308

Note:

  • the config truth is the configuration stored in configuration server (Now is pd)
  • the client(TiKV/TiFlash Nodes) watch the configuration and updates the changes in memory, affect the local config. (I suggest not rely on config file, the client only use it in memory)
@nolouch nolouch added the type/feature-request Categorizes issue or PR as related to a new feature. label Dec 19, 2022
@HuSharp
Copy link
Member

HuSharp commented Dec 20, 2022

/assign

ti-chi-bot added a commit that referenced this issue Jan 17, 2023
ref #5794

This PR is used to modify client config interface. 
This PR will delete the original implementation and tests, which can be added back once #5830 is merged.

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this issue Jan 19, 2023
close #5794

Support resource group watch

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants