-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support resource group watch #5830
Support resource group watch #5830
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @HuSharp. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3fc7577
to
4366236
Compare
fb9a3db
to
23c074a
Compare
003db29
to
51f33da
Compare
51f33da
to
4b06244
Compare
9cfe759
to
492c62c
Compare
Codecov ReportBase: 75.42% // Head: 75.46% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5830 +/- ##
==========================================
+ Coverage 75.42% 75.46% +0.03%
==========================================
Files 341 341
Lines 34336 34404 +68
==========================================
+ Hits 25897 25962 +65
+ Misses 6209 6196 -13
- Partials 2230 2246 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: husharp <jinhao.hu@pingcap.com>
// TODO: complete this function with new implementation. | ||
return nil, nil | ||
// register watch components | ||
globalConfigWatcherCh := make(chan []GlobalConfigItem, 16) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to return the max revision of each []GlobalConfigItem so the caller can do incremental retry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since resource client is just for testing, I will add a retry mechanism after I solve pd client/tidb/CDC compatibility...
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@glorv @nolouch @BornChanger @CabinfeverB pls take a look, thx! |
Signed-off-by: husharp <jinhao.hu@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@glorv: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: husharp <jinhao.hu@pingcap.com>
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 4bd95b5
|
/run-all-tests |
/rebuild |
@HuSharp: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/test build |
What problem does this PR solve?
Issue Number: Close #5794 Ref tikv/tikv#14022
What is changed and how does it work?
Check List
Tests
Release note