-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: upgrade kvproto to the latest master #5861
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
d86f309
to
4f80965
Compare
Codecov ReportBase: 75.46% // Head: 75.43% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5861 +/- ##
==========================================
- Coverage 75.46% 75.43% -0.03%
==========================================
Files 337 337
Lines 34146 34122 -24
==========================================
- Hits 25768 25740 -28
- Misses 6142 6162 +20
+ Partials 2236 2220 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
639c7dc
to
67dc538
Compare
Signed-off-by: Ryan Leung <rleungx@gmail.com>
67dc538
to
15715e2
Compare
After this PR is merged, it will have some compatibility issues if we upgrade pd client dependency in some repo, e.g., TiDB. /cc @HuSharp |
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 15715e2
|
@rleungx: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: Ryan Leung rleungx@gmail.com
What problem does this PR solve?
Issue Number: Ref #4399.
What is changed and how does it work?
Because pingcap/kvproto#1024 is merged, when we upgrade kvproto, it will have some dependency problems. This PR is used to replace the right version of gRPC dependency. Besides, pingcap/kvproto#1035 will introduce some compatibility problems, which this PR will delete the original implementation and tests, which can be added back once #5830 is merged.
Check List
Tests
Release note