Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: both Support names and config path #5885

Closed
HuSharp opened this issue Jan 31, 2023 · 0 comments · Fixed by #5886
Closed

client: both Support names and config path #5885

HuSharp opened this issue Jan 31, 2023 · 0 comments · Fixed by #5886
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@HuSharp
Copy link
Member

HuSharp commented Jan 31, 2023

Enhancement Task

The global config needs to support both names and configuration paths, not only for compatibility but also to make more sense.
@HuSharp HuSharp added the type/enhancement The issue or PR belongs to an enhancement. label Jan 31, 2023
@HuSharp HuSharp mentioned this issue Jan 31, 2023
Merged
ti-chi-bot added a commit that referenced this issue Feb 2, 2023
@HuSharp @ti-chi-bot
client: both Support names and config path (#5886)
18df271 
close #5885, ref #5887, ref #5888, ref pingcap/tiflow#8110

The global config needs to support both names and configuration paths, not only for compatibility but also to make more sense.

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

client: both Support names and config path HuSharp/pd
1 participant
@HuSharp