resource_manager, storage: create new storage endpoint for resource manager #5887
Conversation
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/needs-linked-issue
release-note
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
ti-chi-bot
added
release-note-none
|
@HuSharp: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
| @@ -1888,9 +1888,9 @@ func (s *GrpcServer) StoreGlobalConfig(_ context.Context, request *pdpb.StoreGlo | |||
| name := item.GetName() | |||
| switch item.GetKind() { | |||
| case pdpb.EventType_PUT: | |||
| ops[i] = clientv3.OpPut(s.GetFinalPathWithinPD(request.GetConfigPath()+name), item.GetValue()) | |||
| ops[i] = clientv3.OpPut(request.GetConfigPath()+name, item.GetValue()) | |||
There was a problem hiding this comment.
nit: this line, compared to line 1893, has different coding style
There was a problem hiding this comment.
"...)+name vs. "...) + name"
There was a problem hiding this comment.
This style is generated by go fmt
| @@ -43,6 +42,8 @@ const ( | |||
| keyspaceIDInfix = "id" | |||
| keyspaceAllocID = "alloc_id" | |||
| regionPathPrefix = "raft/r" | |||
| // resource group storage endpoint has prefix `resource_group` | |||
| resourceGroupSettingsPath = "settings" | |||
There was a problem hiding this comment.
nit: alignment problem around "=".
There was a problem hiding this comment.
According to the Go code formatter, it's separated by the comment above, so there is no need to align it with other equality signs.
|
@binshi-bing: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ti-chi-bot
added
status/LGT2
|
/merge |
|
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: c83465f
|
ti-chi-bot
added
the
status/can-merge
close #5885, ref #5887, ref #5888, ref pingcap/tiflow#8110 The global config needs to support both names and configuration paths, not only for compatibility but also to make more sense. Signed-off-by: husharp <jinhao.hu@pingcap.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: Cabinfever_B cabinfeveroier@gmail.com
What problem does this PR solve?
Issue Number: Ref #5851
This PR and #5886 will fix #pingcap/tiflow#8110
What is changed and how does it work?
Create a new storage endpoint and uses separate root path different from PD server
Check List
Tests
Code changes
Release note