Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv leader are unbalanced during br full restore data #6017

Closed
Lily2025 opened this issue Feb 17, 2023 · 4 comments · Fixed by #6054
Closed

tikv leader are unbalanced during br full restore data #6017

Lily2025 opened this issue Feb 17, 2023 · 4 comments · Fixed by #6054
Assignees
@HunDunDM
Labels
affects-6.1 affects-6.5 severity/moderate type/bug The issue is confirmed as a bug.

Comments

@Lily2025
Copy link

Lily2025 commented Feb 17, 2023 •
edited
Loading

Bug Report

What did you do?

6 tikvs（8c/32g）with az label
br full restore 20000 warehouse
https://tcms.pingcap.net/dashboard/executions/plan/1562736

What did you expect to see?

pd leader are balanced during br full restore data
8da2338a-947a-456c-979f-6a91dcc8569b

What did you see instead?

pd leader are unbalanced during br full restore data

What version of PD are you using (pd-server -V)?

./pd-server -V
Release Version: v6.6.0
Edition: Community
Git Commit Hash: 67c0fa2
Git Branch: heads/refs/tags/v6.6.0
UTC Build Time: 2023-02-14 11:56:24
2023-02-17T03:25:41.343Z INFO k8s/client.go:132
@Lily2025 Lily2025 added the type/bug The issue is confirmed as a bug. label Feb 17, 2023
@Lily2025
Copy link
Author

/type bug
/severity major
/assign HunDunDM

@Lily2025
Copy link
Author

/remove-severity major
/severity Moderate

@Lily2025 Lily2025 changed the title pd leader are unbalanced during br full restore data tikv leader are unbalanced during br full restore data Feb 21, 2023
@HunDunDM
Copy link
Member

This bug was introduced by #5663 , NewPlacementLeaderSafeguard excessively limited the Target Stores of the move leader, resulting in an unexpected reduction in the set of optional Leaders.

@HunDunDM HunDunDM mentioned this issue Feb 27, 2023
Merged
@HunDunDM
Copy link
Member

Run the unittest ( from #6054 ) on master:

StoreID Peers Count Leaders Count
2 150 50
3 150 150
4 150 50
5 150 0
6 150 50
7 150 0

Run the unittest on #6054 :

StoreID Peers Count Leaders Count
2 150 50
3 150 50
4 150 50
5 150 50
6 150 50
7 150 50

ti-chi-bot pushed a commit that referenced this issue Feb 28, 2023
@HunDunDM
region_scatter: fix a bug that the leaders may be unbalanced after sc…
710b511 
…atter region (#6054)

close #6017

Signed-off-by: HunDunDM <hundundm@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this issue Feb 28, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Feb 28, 2023
@HunDunDM @ti-chi-bot
This is an automated cherry-pick of tikv#6054
5b4f30f 
close tikv#6017

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Feb 28, 2023
Merged
ti-chi-bot added a commit that referenced this issue Mar 1, 2023
@ti-chi-bot @HunDunDM
region_scatter: fix a bug that the leaders may be unbalanced after sc…
e4a9312 
…atter region (#6054) (#6061)

close #6017, ref #6054

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
@nolouch nolouch mentioned this issue Mar 7, 2023
Merged
16 tasks
@rleungx rleungx mentioned this issue Mar 23, 2023
Merged
15 tasks
ti-chi-bot added a commit that referenced this issue Mar 27, 2023
@ti-chi-bot @CabinfeverB
region_scatter: fix a bug that the leaders may be unbalanced after sc…
39a4de6 
…atter region (#6054) (#6060)

close #6017, ref #6054

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: Cabinfever_B <cabinfeveroier@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HunDunDM HunDunDM

Labels
affects-6.1 affects-6.5 severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

region_scatter: fix a bug that the leaders may be unbalanced after scatter region HunDunDM/pd
4 participants
@HunDunDM @CabinfeverB @ti-chi-bot @Lily2025