Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

region_scatter: fix a bug that the leaders may be unbalanced after scatter region #6054

Merged
merged 4 commits into from
Feb 28, 2023
Merged

region_scatter: fix a bug that the leaders may be unbalanced after scatter region #6054

merged 4 commits into from
Feb 28, 2023

Conversation

HunDunDM
Copy link
Member

@HunDunDM HunDunDM commented Feb 27, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #6017

What is changed and how does it work?

Use a more correct method to select candidate leaders.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

Fix a bug that the leaders may be unbalanced during scatter region.

@HunDunDM
add unittest
81eca81 
Signed-off-by: HunDunDM <hundundm@gmail.com>
@HunDunDM
region_scatter: fix a bug that the leaders may be unbalanced after sc…
275a245 
…atter region

Signed-off-by: HunDunDM <hundundm@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 27, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Feb 27, 2023
@HunDunDM HunDunDM mentioned this pull request Feb 27, 2023
Closed
@HunDunDM
tiny fix
42a7824 
Signed-off-by: HunDunDM <hundundm@gmail.com>
CabinfeverB
CabinfeverB approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@CabinfeverB CabinfeverB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

server/schedule/region_scatterer.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 27, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 28, 2023
@HunDunDM
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e6796b5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 28, 2023
@ti-chi-bot ti-chi-bot merged commit 710b511 into tikv:master Feb 28, 2023
@HunDunDM HunDunDM deleted the fix-6017 branch February 28, 2023 07:15
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 28, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #6060.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 28, 2023
@HunDunDM @ti-chi-bot
This is an automated cherry-pick of tikv#6054
5b4f30f 
close tikv#6017

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 28, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #6061.

ti-chi-bot added a commit that referenced this pull request Mar 1, 2023
@ti-chi-bot @HunDunDM
region_scatter: fix a bug that the leaders may be unbalanced after sc…
e4a9312 
…atter region (#6054) (#6061)

close #6017, ref #6054

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot added a commit that referenced this pull request Mar 27, 2023
@ti-chi-bot @CabinfeverB
region_scatter: fix a bug that the leaders may be unbalanced after sc…
39a4de6 
…atter region (#6054) (#6060)

close #6017, ref #6054

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: Cabinfever_B <cabinfeveroier@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tikv leader are unbalanced during br full restore data
4 participants
@HunDunDM @ti-chi-bot @lhy1024 @CabinfeverB