Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic during initializing ResourceGroupController #7360

Closed
JmPotato opened this issue Nov 13, 2023 · 1 comment · Fixed by #7361
Closed

Panic during initializing ResourceGroupController #7360

JmPotato opened this issue Nov 13, 2023 · 1 comment · Fixed by #7361
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. component/client Client logic. component/resource-control severity/minor type/bug The issue is confirmed as a bug.

Comments

@JmPotato
Copy link
Member

Bug Report

After updating the PD client version of TiDB, this panic occurs:

image

https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fghpr_unit_test/detail/ghpr_unit_test/37306/pipeline

Might be related to #7042.
@JmPotato JmPotato added type/bug The issue is confirmed as a bug. component/client Client logic. component/resource-control labels Nov 13, 2023
@JmPotato JmPotato mentioned this issue Nov 13, 2023
Merged
@JmPotato
Copy link
Member Author

Root cause: we may have a mock PD client as the config provider which will give a nil response:

https://github.com/tikv/client-go/blob/9caddec1314fc756f843d7b6046038d97612f7a9/internal/mockstore/mocktikv/pd.go#L395-L397

ti-chi-bot bot pushed a commit that referenced this issue Nov 13, 2023
@JmPotato
resource_controller: prevent loadServerConfig from panic (#7361)
be31c08 
close #7360

Prevent `loadServerConfig` from panic.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@nolouch nolouch added the affects-7.5 This bug affects the 7.5.x(LTS) versions. label Nov 16, 2023
@ti-chi-bot ti-chi-bot mentioned this issue Nov 16, 2023
Closed
nolouch pushed a commit to ti-chi-bot/pd that referenced this issue Nov 16, 2023
@JmPotato @nolouch
resource_controller: prevent loadServerConfig from panic (tikv#7361)
4255a28 
close tikv#7360

Prevent `loadServerConfig` from panic.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. component/client Client logic. component/resource-control severity/minor type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resource_controller: prevent loadServerConfig from panic JmPotato/pd
2 participants
@JmPotato @nolouch