Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_controller: prevent loadServerConfig from panic (#7361) #7384

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7361

What problem does this PR solve?

Issue Number: close #7360.

What is changed and how does it work?

Prevent `loadServerConfig` from panic.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

image

Release note

None.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Nov 16, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added component/client Client logic. component/resource-control release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 16, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 16, 2023

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #7384 (ead03d5) into release-7.5 (d0a17ca) will increase coverage by 0.02%.
The diff coverage is 66.66%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.5    #7384      +/-   ##
===============================================
+ Coverage        74.61%   74.63%   +0.02%     
===============================================
  Files              442      442              
  Lines            47822    47823       +1     
===============================================
+ Hits             35682    35695      +13     
+ Misses            8985     8969      -16     
- Partials          3155     3159       +4     
Flag Coverage Δ
unittests 74.63% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 16, 2023
@nolouch
Copy link
Contributor

nolouch commented Nov 16, 2023

included in #7384

@nolouch nolouch closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/client Client logic. component/resource-control do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants