Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing trace logs metrics for local controller of resource manager #7509

Closed
nolouch opened this issue Dec 7, 2023 · 0 comments · Fixed by #7510 or #6523
Closed

missing trace logs metrics for local controller of resource manager #7509

nolouch opened this issue Dec 7, 2023 · 0 comments · Fixed by #7510 or #6523
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.

Comments

@nolouch
Copy link
Contributor

nolouch commented Dec 7, 2023

Bug Report

missing some information, which makes it difficult to diagnose the admission control.

What version of PD are you using (pd-server -V)?

master, 7.5, 7.1
@nolouch nolouch added the type/bug The issue is confirmed as a bug. label Dec 7, 2023
@nolouch nolouch mentioned this issue Dec 7, 2023
Merged
@nolouch nolouch added affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. and removed may-affects-5.4 may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 labels Dec 7, 2023
ti-chi-bot bot pushed a commit that referenced this issue Dec 11, 2023
@nolouch @CabinfeverB
resource_control: improve trace logs, ctl and metrics (#7510)
ab68192 
close #7509

resource_control: improve trace logs, ctl and metrics
- add the ctl command to config resource cotnrol
- add metrics and a switch to enable trace log

Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: Shuning Chen <nolouch@ShuningdeMacBook-Pro.local>

Co-authored-by: Shuning Chen <nolouch@ShuningdeMacBook-Pro.local>
Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Dec 11, 2023
@nolouch @ti-chi-bot
This is an automated cherry-pick of tikv#7510
46d699c 
close tikv#7509

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Dec 11, 2023
Merged
Merged
@nolouch nolouch mentioned this issue Dec 11, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Dec 11, 2023
@ti-chi-bot @nolouch @CabinfeverB
resource_control: improve trace logs, ctl and metrics (#7510) (#7523)
fe6fd17 
close #7509

resource_control: improve trace logs, ctl and metrics
- add the ctl command to config resource cotnrol
- add metrics and a switch to enable trace log

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Shuning Chen <nolouch@ShuningdeMacBook-Pro.local>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Shuning Chen <nolouch@ShuningdeMacBook-Pro.local>
Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com>
This was referenced Dec 11, 2023
Merged
Closed
ti-chi-bot bot pushed a commit to pingcap/tidb that referenced this issue Dec 11, 2023
@nolouch
gomod: update the pd client for release-7.1 (#49342)
126cf52 
close tikv/pd#7509
ti-chi-bot bot added a commit that referenced this issue Dec 12, 2023
@ti-chi-bot @nolouch @ti-chi-bot
resource_control: improve trace logs, ctl and metrics (#7510) (#7524)
3d7f65e 
close #7509

resource_control: improve trace logs, ctl and metrics
- add the ctl command to config resource cotnrol
- add metrics and a switch to enable trace log

Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: Shuning Chen <nolouch@ShuningdeMacBook-Pro.local>

Co-authored-by: nolouch <nolouch@gmail.com>
Co-authored-by: Shuning Chen <nolouch@ShuningdeMacBook-Pro.local>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@nolouch nolouch mentioned this issue Apr 7, 2024
Merged
ti-chi-bot bot added a commit that referenced this issue Apr 7, 2024
@nolouch @ti-chi-bot
client/controller: add logs and export more information in throttled …
cbde636 
…error (#8028)

ref #7509

Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jun 5, 2024
@nolouch @ti-chi-bot
This is an automated cherry-pick of tikv#8028
14135bd 
ref tikv#7509

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jun 5, 2024
@nolouch @ti-chi-bot
This is an automated cherry-pick of tikv#8028
982bf3c 
ref tikv#7509

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Jun 5, 2024
Merged
Closed
ti-chi-bot bot added a commit that referenced this issue Jun 19, 2024
@ti-chi-bot @nolouch @ti-chi-bot
client/controller: add logs and export more information in throttled …
2807999 
…error (#8028) (#8255)

ref #7509

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: nolouch <nolouch@gmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
Status: Closed
Milestone
No milestone
1 participant
@nolouch