Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_control: improve trace logs, ctl and metrics (#7510) #7524

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7510

What problem does this PR solve?

Issue Number: Close #7509

What is changed and how does it work?

resource_control: improve trace logs, ctl and metrics
- add the ctl command to config resource cotnrol
- add metrics and a switch to enable trace log

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
    image

Release note

None.

nolouch and others added 2 commits December 11, 2023 07:58
Signed-off-by: nolouch <nolouch@gmail.com>

 Please enter the commit message for your changes. Lines starting
Signed-off-by: Shuning Chen <nolouch@ShuningdeMacBook-Pro.local>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 11, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 11, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #7524 (d27545f) into release-7.5 (a5b9d66) will increase coverage by 0.01%.
The diff coverage is 77.27%.

❗ Current head d27545f differs from pull request most recent head dd234d7. Consider uploading reports for the commit dd234d7 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.5    #7524      +/-   ##
===============================================
+ Coverage        74.58%   74.59%   +0.01%     
===============================================
  Files              442      443       +1     
  Lines            47823    47891      +68     
===============================================
+ Hits             35668    35724      +56     
- Misses            9000     9006       +6     
- Partials          3155     3161       +6     
Flag Coverage Δ
unittests 74.59% <77.27%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 11, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 11, 2023
@nolouch nolouch requested review from CabinfeverB and removed request for disksing and rleungx December 11, 2023 10:35
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 12, 2023
@nolouch
Copy link
Contributor

nolouch commented Dec 12, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 12, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 12, 2023

This pull request has been accepted and is ready to merge.

Commit hash: d27545f

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 12, 2023
@ti-chi-bot ti-chi-bot bot merged commit 3d7f65e into tikv:release-7.5 Dec 12, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants