Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs of using pd http client to scan regions #7869

Closed
Smityz opened this issue Mar 1, 2024 · 0 comments · Fixed by #7870
Closed

Bugs of using pd http client to scan regions #7869

Smityz opened this issue Mar 1, 2024 · 0 comments · Fixed by #7870
Labels
severity/moderate type/bug The issue is confirmed as a bug.

Comments

@Smityz
Copy link
Contributor

Smityz commented Mar 1, 2024

Bug Report

What did you do?

use http pd client to scan regions

What did you expect to see?

get correct regions

What did you see instead?

  1. client will panic by using http.NewClient, becase client.serviceModeUpdateCb is null by default
  2. can't get the right regions in range because of different http format

What version of PD are you using (pd-server -V)?

v6.5.3
@Smityz Smityz added the type/bug The issue is confirmed as a bug. label Mar 1, 2024
@Smityz Smityz mentioned this issue Mar 1, 2024
Merged
@ti-chi-bot ti-chi-bot bot closed this as completed in #7870 Mar 5, 2024
ti-chi-bot bot pushed a commit that referenced this issue Mar 5, 2024
@Smityz
client/http: fix the scan region parameter (#7870)
3f67cac 
close #7869

add null pointer check and fix http request format

Signed-off-by: Smityz <smityz@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity/moderate type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

client/http: fix the scan region parameter Smityz/pd
2 participants
@JmPotato @Smityz