Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/http: fix the scan region parameter #7870

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Conversation

Smityz
Copy link
Contributor

@Smityz Smityz commented Mar 1, 2024

What problem does this PR solve?

Issue Number: Close #7869

What is changed and how does it work?

add null pointer check and fix http request format

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: Smityz <smityz@qq.com>
Copy link
Contributor

ti-chi-bot bot commented Mar 1, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Mar 1, 2024
@ti-chi-bot ti-chi-bot bot requested a review from JmPotato March 1, 2024 13:46
@ti-chi-bot ti-chi-bot bot added the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Mar 1, 2024
@ti-chi-bot ti-chi-bot bot requested a review from lhy1024 March 1, 2024 13:46
Copy link
Contributor

ti-chi-bot bot commented Mar 1, 2024

Hi @Smityz. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 1, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Merging #7870 (cf23605) into master (2851db2) will increase coverage by 0.03%.
The diff coverage is 33.33%.

❗ Current head cf23605 differs from pull request most recent head f0a23c3. Consider uploading reports for the commit f0a23c3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7870      +/-   ##
==========================================
+ Coverage   73.44%   73.48%   +0.03%     
==========================================
  Files         433      432       -1     
  Lines       47972    47968       -4     
==========================================
+ Hits        35235    35248      +13     
+ Misses       9691     9670      -21     
- Partials     3046     3050       +4     
Flag Coverage Δ
unittests 73.48% <33.33%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@JmPotato JmPotato changed the title [http] fix bugs of pd http client client/http: fix the scan region parameter Mar 4, 2024
Signed-off-by: Smityz <smityz@qq.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2024
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM.

tests/integrations/client/http_client_test.go Show resolved Hide resolved
Signed-off-by: Smityz <smityz@qq.com>
@Smityz Smityz requested a review from JmPotato March 5, 2024 02:58
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 5, 2024
@JmPotato
Copy link
Member

JmPotato commented Mar 5, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 5, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 5, 2024

This pull request has been accepted and is ready to merge.

Commit hash: f0a23c3

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 5, 2024
@JmPotato
Copy link
Member

JmPotato commented Mar 5, 2024

/check-issue-triage-complete

@JmPotato JmPotato added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Mar 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit 3f67cac into tikv:master Mar 5, 2024
22 checks passed
@Smityz Smityz deleted the cm branch March 5, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugs of using pd http client to scan regions
3 participants