-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strengthen configuration change approval #8167
Labels
type/enhancement
The issue or PR belongs to an enhancement.
Comments
/assign wuhuizuo |
This was referenced May 15, 2024
wuhuizuo
added a commit
to wuhuizuo/pd
that referenced
this issue
May 27, 2024
1 task
wuhuizuo
added a commit
to wuhuizuo/pd
that referenced
this issue
May 27, 2024
Close tikv#8167 Signed-off-by: wuhuizuo <wuhuizuo@126.com>
wuhuizuo
added a commit
to wuhuizuo/pd
that referenced
this issue
Jun 4, 2024
Close tikv#8167 Signed-off-by: wuhuizuo <wuhuizuo@126.com>
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Jun 5, 2024
Close tikv#8167 Signed-off-by: wuhuizuo <wuhuizuo@126.com>
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Jun 5, 2024
Close tikv#8167 Signed-off-by: wuhuizuo <wuhuizuo@126.com>
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Jun 5, 2024
Close tikv#8167 Signed-off-by: wuhuizuo <wuhuizuo@126.com>
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Jun 5, 2024
Close tikv#8167 Signed-off-by: wuhuizuo <wuhuizuo@126.com>
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Jun 5, 2024
Close tikv#8167 Signed-off-by: wuhuizuo <wuhuizuo@126.com>
ti-chi-bot bot
pushed a commit
that referenced
this issue
Sep 6, 2024
ref #8167 Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Strengthen configuration change approval
An approval process for the change to the file path scope of global variables and configurations will be deployed.
Why
The current reviewers and approvers are at the code repository level and are not subdivided into specific areas, can not fine-grained control over changes in important areas. Configuration/variable changes can have a wide-ranging impact, affecting system stability and compatibility. Recently, there have been several online issues caused by configuration/variable changes.
To minimize the negative impact of configuration/variable changes, ensure that each change undergoes careful consideration and evaluation and comes with clear documentation, and reduce the risk of online issues, we plan to pilot pre-approval of configuration changes in the
tikv/pd
repo and delegate the approval responsibility to the person in charge of maintaining the TiDB product.What's new for developer
The reviewing control framework will be migrated to the native "lgtm" and "approve" plug-ins. In terms of final approval, it will change from a single merge approval (a "/merge" command) to an approval mode by responsible area (one or more "/ approve" command).
All the changes need to be approved by committers or maintainers as before except if there are configurations changes, the PRs need also to be approved by approvers inside
/OWNERS_ALIASES
file. The approvers will be automatically recommended by bot on GitHub.Ref:
Set up
OWNERS
mechanism to control the approving for pull requests, here is the PR review flow.OWNERS_ALIASES
file in root folder in repository to maintain the approver teams for variable or configuration changes.OWNERS
files in sub folders to support approving by folder or file paths. And make it not inherit from parentOWNERS
files to ensure the changes must be approved by the dedicated approvers.OWNERS
files(layer by layer in folder level), and leaf approvers first.OWNERS
andOWNERS_ALIASES
files should be updated on time.OWNERS
files in the leaf folders./OWNERS_ALIASES
file.Role and Responsibility
pingcap/docs
,pingcap/docs-cn
), adding the changes to release notes, and updating relevant documentation, to ensure that users have access to accurate and up-to-date information.The text was updated successfully, but these errors were encountered: