Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add prow OWNERS files to control the approvals for critical configuration files #8218

Merged
merged 12 commits into from
Jun 4, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented May 27, 2024

What problem does this PR solve?

Issue Number: Close #8167

What is changed and how does it work?

Check List

Tests

  • No code

Code changes

  • None

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch: release-8.1, release-7.5, release-7.1, release-6.5, release-6.1

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented May 27, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels May 27, 2024
Copy link
Contributor

ti-chi-bot bot commented May 27, 2024

Hi @wuhuizuo. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx May 27, 2024 12:08
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 27, 2024
@wuhuizuo wuhuizuo force-pushed the wuhuizuo/issue8167 branch from bfc13bb to 7d8d6e0 Compare May 27, 2024 12:09
@wuhuizuo
Copy link
Contributor Author

/hold

let @wuhuizuo to decide when to merge it.

@wuhuizuo wuhuizuo marked this pull request as ready for review May 27, 2024 12:11
@ti-chi-bot ti-chi-bot bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 27, 2024
@wuhuizuo
Copy link
Contributor Author

/cc @easonn7 @kevin-xianliu @niubell

Copy link
Contributor

ti-chi-bot bot commented May 27, 2024

@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: easonn7, kevin-xianliu, niubell.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @easonn7 @kevin-xianliu @niubell

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.41%. Comparing base (fcec188) to head (b565a1e).

Current head b565a1e differs from pull request most recent head 2a8a19b

Please upload reports for the commit 2a8a19b to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8218      +/-   ##
==========================================
+ Coverage   77.29%   77.41%   +0.11%     
==========================================
  Files         471      471              
  Lines       61377    61369       -8     
==========================================
+ Hits        47441    47507      +66     
+ Misses      10373    10305      -68     
+ Partials     3563     3557       -6     
Flag Coverage Δ
unittests 77.41% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

OWNERS_ALIASES Outdated Show resolved Hide resolved
client/tlsutil/OWNERS Outdated Show resolved Hide resolved
conf/OWNERS Outdated Show resolved Hide resolved
pkg/encryption/OWNERS Outdated Show resolved Hide resolved
pkg/mcs/tso/server/OWNERS Outdated Show resolved Hide resolved
pkg/schedule/config/OWNERS Outdated Show resolved Hide resolved
server/config/OWNERS Outdated Show resolved Hide resolved
@wuhuizuo wuhuizuo force-pushed the wuhuizuo/issue8167 branch from a285f03 to e00160b Compare May 27, 2024 12:27
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jun 4, 2024

/cc @easonn7 @kevin-xianliu @niubell

Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: easonn7, kevin-xianliu, niubell.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @easonn7 @kevin-xianliu @niubell

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wuhuizuo added 3 commits June 4, 2024 16:41
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@wuhuizuo wuhuizuo force-pushed the wuhuizuo/issue8167 branch from b565a1e to 2a8a19b Compare June 4, 2024 08:41
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. labels Jun 4, 2024
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jun 4, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2024
@lhy1024
Copy link
Contributor

lhy1024 commented Jun 4, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 2a8a19b

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit 492a873 into tikv:master Jun 4, 2024
15 checks passed
@wuhuizuo wuhuizuo deleted the wuhuizuo/issue8167 branch June 4, 2024 08:49
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jun 5, 2024

/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-6.1: #8248.

In response to this:

/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-6.5: #8249.

In response to this:

/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-7.1: #8250.

In response to this:

/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-7.5: #8251.

In response to this:

/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-8.1: #8252.

In response to this:

/cherry-pick release-8.1
/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot added a commit that referenced this pull request Jun 7, 2024
…nfiguration files (#8218) (#8252)

close #8167

Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Co-authored-by: wuhuizuo <wuhuizuo@126.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this pull request Jun 7, 2024
…nfiguration files (#8218) (#8250)

close #8167

Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Co-authored-by: wuhuizuo <wuhuizuo@126.com>
ti-chi-bot bot pushed a commit that referenced this pull request Jun 7, 2024
…nfiguration files (#8218) (#8249)

close #8167

Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Co-authored-by: wuhuizuo <wuhuizuo@126.com>
ti-chi-bot bot pushed a commit that referenced this pull request Jun 11, 2024
…nfiguration files (#8218) (#8248)

close #8167

Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Co-authored-by: wuhuizuo <wuhuizuo@126.com>
Co-authored-by: husharp <jinhao.hu@pingcap.com>
ti-chi-bot bot added a commit that referenced this pull request Jun 11, 2024
…nfiguration files (#8218) (#8251)

close #8167

Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Co-authored-by: wuhuizuo <wuhuizuo@126.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strengthen configuration change approval
4 participants