Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance ttl config api output #8450

Closed
lhy1024 opened this issue Jul 26, 2024 · 1 comment · Fixed by #8451
Closed

enhance ttl config api output #8450

lhy1024 opened this issue Jul 26, 2024 · 1 comment · Fixed by #8451
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@lhy1024
Copy link
Contributor

lhy1024 commented Jul 26, 2024

Enhancement Task

  1. I run a cluster with TTL config and I cannot modify it directly.
» config set merge-schedule-limit 16
Failed to set config: [400] "need to clean up TTL first for schedule.merge-schedule-limit"
  1. I try to call API to delete it. Although it shows "config is updated", it is not changed.
curl -X POST -H "Content-Type: application/json" -d '{"schedule.merge-schedule-limit": 16}' "http://<ip_address>:<port>/pd/api/v1/config?ttlSecond=0"

img_v3_02d5_87b2eb55-2df5-4c1b-87c6-9f8b9a6d41dg
img_v3_02d5_edcdbad8-075e-47e1-ba46-0e064efb86bg

@lhy1024 lhy1024 added the type/enhancement The issue or PR belongs to an enhancement. label Jul 26, 2024
@lhy1024
Copy link
Contributor Author

lhy1024 commented Jul 26, 2024

actually, we only delete ttl config when post with ?ttlSecond=0 and we need to modify config with pd-ctl again.

ti-chi-bot bot added a commit that referenced this issue Jul 29, 2024
close #8450

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant