Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: enhance ttl config api output #8451

Merged
merged 2 commits into from
Jul 29, 2024
Merged

api: enhance ttl config api output #8451

merged 2 commits into from
Jul 29, 2024

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jul 26, 2024

What problem does this PR solve?

Issue Number: Close #8450

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 26, 2024

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 29, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-29 04:28:19.95821917 +0000 UTC m=+157216.238267240: ☑️ agreed by nolouch.
  • 2024-07-29 05:06:42.807657033 +0000 UTC m=+159519.087705087: ☑️ agreed by rleungx.

Copy link
Contributor

ti-chi-bot bot commented Jul 29, 2024

@lhy1024: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-realcluster-test 2cfbe4f link false /test pull-integration-realcluster-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Jul 29, 2024

/test pull-integration-realcluster-test

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.32%. Comparing base (11da622) to head (2cfbe4f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8451      +/-   ##
==========================================
- Coverage   77.35%   77.32%   -0.03%     
==========================================
  Files         472      472              
  Lines       61799    61802       +3     
==========================================
- Hits        47803    47788      -15     
- Misses      10432    10439       +7     
- Partials     3564     3575      +11     
Flag Coverage Δ
unittests 77.32% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot merged commit c53f1d5 into tikv:master Jul 29, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhance ttl config api output
4 participants