Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: validate dashboard-address (#2517) #2522

Merged
merged 3 commits into from
Jun 15, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jun 8, 2020

cherry-pick #2517 to release-4.0


Signed-off-by: Zheng Xiangsheng hundundm@gmail.com

What problem does this PR solve?

What is changed and how it works?

  • When setting the pd-server config, validate the dashboard-address and reject the incorrect setting.

Check List

Tests

  • Unit test

Release note

Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2522 into release-4.0 will increase coverage by 0.58%.
The diff coverage is 67.50%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2522      +/-   ##
===============================================
+ Coverage        77.07%   77.66%   +0.58%     
===============================================
  Files              204      204              
  Lines            21905    21940      +35     
===============================================
+ Hits             16883    17039     +156     
+ Misses            3731     3616     -115     
+ Partials          1291     1285       -6     
Impacted Files Coverage Δ
pkg/dashboard/adapter/manager.go 86.79% <ø> (+2.38%) ⬆️
server/server.go 77.25% <28.57%> (-0.29%) ⬇️
server/cluster/cluster.go 83.64% <66.66%> (+3.35%) ⬆️
pkg/dashboard/adapter/redirector.go 94.23% <100.00%> (ø)
server/config/config.go 78.92% <100.00%> (+0.92%) ⬆️
server/config/util.go 89.47% <100.00%> (+6.14%) ⬆️
server/schedulers/random_merge.go 61.19% <0.00%> (-2.99%) ⬇️
client/base_client.go 88.59% <0.00%> (-2.02%) ⬇️
server/tso/tso.go 81.02% <0.00%> (ø)
server/grpc_service.go 60.92% <0.00%> (+0.38%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30f0b01...f1354ec. Read the comment docs.

@HunDunDM HunDunDM modified the milestones: v4.0.1, v4.0.2 Jun 8, 2020
@HunDunDM
Copy link
Member

HunDunDM commented Jun 9, 2020

/run-all-tests

@disksing
Copy link
Contributor

disksing commented Jun 9, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 9, 2020

Sorry @disksing, you don't have permission to trigger auto merge event on this branch.
The version releasement is in progress.

@disksing
Copy link
Contributor

disksing commented Jun 9, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 9, 2020

Sorry @disksing, you don't have permission to trigger auto merge event on this branch.
The version releasement is in progress.

@disksing
Copy link
Contributor

disksing commented Jun 9, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 9, 2020

Sorry @disksing, you don't have permission to trigger auto merge event on this branch.
The version releasement is in progress.

@disksing
Copy link
Contributor

disksing commented Jun 9, 2020

sorry @sre-bot

@nolouch
Copy link
Contributor

nolouch commented Jun 10, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 10, 2020

Sorry @nolouch, you don't have permission to trigger auto merge event on this branch.
The version releasement is in progress.

@nolouch
Copy link
Contributor

nolouch commented Jun 15, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 15, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 15, 2020

/run-all-tests

@sre-bot sre-bot merged commit 85a49d5 into tikv:release-4.0 Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config Configuration logic. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants