cluster: save to the region cache when pending-peers or down-peers change #3462

HunDunDM · 2021-03-10T15:08:57Z

What problem does this PR solve?

close #3456

What is changed and how it works?

Before: save to the region cache when pending-peers or down-peers exists
After: save to the region cache when pending-peers or down-peers change

Check List

Tests

Unit test

Related changes

Need to cherry-pick to the release branch

Release note

save to the region cache when pending-peers or down-peers change

…ange Signed-off-by: HunDunDM <hundundm@gmail.com>

Signed-off-by: HunDunDM <hundundm@gmail.com>

codecov · 2021-03-10T15:33:15Z

Codecov Report

Merging #3462 (26f7dcf) into master (0b7e2e8) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3462      +/-   ##
==========================================
+ Coverage   74.90%   74.98%   +0.08%     
==========================================
  Files         244      244              
  Lines       23559    23578      +19     
==========================================
+ Hits        17646    17680      +34     
+ Misses       4322     4315       -7     
+ Partials     1591     1583       -8

Flag	Coverage Δ
unittests	`74.98% <100.00%> (+0.08%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/cluster/cluster.go	`83.17% <100.00%> (+0.04%)`	⬆️
server/core/region.go	`90.33% <100.00%> (+0.35%)`	⬆️
server/core/region_option.go	`83.33% <100.00%> (+0.40%)`	⬆️
server/tso/local_allocator.go	`72.46% <0.00%> (-7.25%)`	⬇️
server/server.go	`71.98% <0.00%> (-0.78%)`	⬇️
server/grpc_service.go	`57.26% <0.00%> (-0.51%)`	⬇️
server/handler.go	`41.97% <0.00%> (-0.50%)`	⬇️
client/client.go	`67.01% <0.00%> (-0.18%)`	⬇️
server/tso/tso.go	`72.39% <0.00%> (+0.61%)`	⬆️
server/tso/allocator_manager.go	`75.58% <0.00%> (+0.83%)`	⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b7e2e8...26f7dcf. Read the comment docs.

nolouch

lgtm

rleungx · 2021-03-11T08:45:50Z

server/cluster/cluster.go

-		if len(region.GetDownPeers()) > 0 || len(region.GetPendingPeers()) > 0 {
-			saveCache = true
+		if !core.SortedPeersStatsEqual(region.GetDownPeers(), origin.GetDownPeers()) {
+			log.Debug("down-peers changed", zap.Uint64("region-id", region.GetID()))


How about printing the difference?

Personally, I think pending is more common, so I used the Debug level.

ti-chi-bot · 2021-03-12T08:59:24Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

lhy1024
nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

lhy1024 · 2021-03-12T09:30:53Z

/merge

ti-chi-bot · 2021-03-12T09:30:54Z

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-03-12T09:30:55Z

This pull request has been accepted and is ready to merge.

Commit hash: e23b725

HunDunDM · 2021-03-12T09:44:02Z

/run-all-tests

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-03-12T10:01:15Z

cherry pick to release-3.0 in PR #3470

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-03-12T10:01:44Z

cherry pick to release-4.0 in PR #3471

…ange (#3462) (#3471) * cherry pick #3462 to release-4.0 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * fix Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: 混沌DM <hundundm@gmail.com> Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>

HunDunDM added 2 commits March 10, 2021 22:33

cluster: save to the region cache when pending-peers or down-peers ch…

abc049c

…ange Signed-off-by: HunDunDM <hundundm@gmail.com>

add unit test

8866c8e

Signed-off-by: HunDunDM <hundundm@gmail.com>

HunDunDM requested a review from nolouch March 10, 2021 15:09

ti-chi-bot requested a review from rleungx March 10, 2021 15:09

HunDunDM added component/cluster Cluster logic. needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. type/bugfix This PR fixes a bug. labels Mar 10, 2021

HunDunDM self-assigned this Mar 10, 2021

fix typo

e23b725

Signed-off-by: HunDunDM <hundundm@gmail.com>

nolouch reviewed Mar 10, 2021

View reviewed changes

nolouch approved these changes Mar 10, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 10, 2021

rleungx reviewed Mar 11, 2021

View reviewed changes

lhy1024 approved these changes Mar 12, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 12, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2021

Merge branch 'master' into pending-down

26f7dcf

ti-chi-bot merged commit b1ba2d0 into tikv:master Mar 12, 2021

ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Mar 12, 2021

cherry pick tikv#3462 to release-3.0

8d2d2f9

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Mar 12, 2021

cluster: save to the region cache when pending-peers or down-peers change (#3462) #3470

Closed

HunDunDM deleted the pending-down branch March 12, 2021 10:01

ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Mar 12, 2021

cherry pick tikv#3462 to release-4.0

01e696f

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Mar 12, 2021

cluster: save to the region cache when pending-peers or down-peers change (#3462) #3471

Merged

HunDunDM mentioned this pull request Sep 6, 2021

checker: judging that the peer is down is no longer based on DownSeconds #4078

Merged

HunDunDM mentioned this pull request Sep 28, 2021

checker: judging that the peer is down is no longer based on DownSeconds (#4078) #4178

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cluster: save to the region cache when pending-peers or down-peers change #3462

cluster: save to the region cache when pending-peers or down-peers change #3462

HunDunDM commented Mar 10, 2021

codecov bot commented Mar 10, 2021 •

edited

Loading

nolouch left a comment

rleungx Mar 11, 2021

HunDunDM Mar 11, 2021

ti-chi-bot commented Mar 12, 2021

lhy1024 commented Mar 12, 2021

ti-chi-bot commented Mar 12, 2021

ti-chi-bot commented Mar 12, 2021

HunDunDM commented Mar 12, 2021

ti-srebot commented Mar 12, 2021

ti-srebot commented Mar 12, 2021

cluster: save to the region cache when pending-peers or down-peers change #3462

cluster: save to the region cache when pending-peers or down-peers change #3462

Conversation

HunDunDM commented Mar 10, 2021

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

codecov bot commented Mar 10, 2021 • edited Loading

Codecov Report

nolouch left a comment

Choose a reason for hiding this comment

rleungx Mar 11, 2021

Choose a reason for hiding this comment

HunDunDM Mar 11, 2021

Choose a reason for hiding this comment

ti-chi-bot commented Mar 12, 2021

lhy1024 commented Mar 12, 2021

ti-chi-bot commented Mar 12, 2021

ti-chi-bot commented Mar 12, 2021

HunDunDM commented Mar 12, 2021

ti-srebot commented Mar 12, 2021

ti-srebot commented Mar 12, 2021

codecov bot commented Mar 10, 2021 •

edited

Loading