checker: judging that the peer is down is no longer based on DownSeconds #4078

HunDunDM · 2021-09-06T04:37:45Z

Signed-off-by: HunDunDM hundundm@gmail.com

What problem does this PR solve?

Fix #4077 #4027

After #3462, DownSeconds no longer update with the heartbeat. It will cause the down-peer to not be repaired in time.

What is changed and how it works?

Judging that the peer is down is no longer based on DownSeconds.

Check List

Tests

Unit test

Code changes

Side effects

Breaking backward compatibility
- PD judge that the peer is down is no longer based on DownSeconds. In extreme cases, down-peers that would not have been processed will be fixed.

Related changes

Need to cherry-pick to the release branch

Release note

Fix the bug that PD would not fix down-peer in time.

Signed-off-by: HunDunDM <hundundm@gmail.com>

ti-chi-bot · 2021-09-06T04:37:46Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

lhy1024
nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

disksing · 2021-09-06T05:15:55Z

does it break compatibility?

Signed-off-by: HunDunDM <hundundm@gmail.com>

nolouch · 2021-09-06T06:46:17Z

/merge

ti-chi-bot · 2021-09-06T06:46:18Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-09-06T06:46:19Z

@nolouch: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

nolouch · 2021-09-06T06:46:31Z

/merge

ti-chi-bot · 2021-09-06T06:46:32Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-09-06T06:46:33Z

This pull request has been accepted and is ready to merge.

Commit hash: 0fdb1e1

HunDunDM · 2021-09-06T06:59:41Z

/rebuild

nolouch · 2021-09-06T07:20:24Z

/rebuild

codecov · 2021-09-06T07:57:56Z

Codecov Report

Merging #4078 (bb89d4e) into master (a82d232) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4078      +/-   ##
==========================================
+ Coverage   74.67%   74.69%   +0.02%     
==========================================
  Files         258      258              
  Lines       26088    26084       -4     
==========================================
+ Hits        19481    19484       +3     
+ Misses       4877     4873       -4     
+ Partials     1730     1727       -3

Flag	Coverage Δ
unittests	`74.69% <ø> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/schedule/checker/replica_checker.go	`71.11% <ø> (+1.03%)`	⬆️
server/schedule/checker/rule_checker.go	`82.88% <ø> (+0.87%)`	⬆️
server/region_syncer/server.go	`83.21% <0.00%> (-5.84%)`	⬇️
server/id/id.go	`76.19% <0.00%> (-4.77%)`	⬇️
server/member/member.go	`63.10% <0.00%> (-3.21%)`	⬇️
server/core/storage.go	`68.04% <0.00%> (-1.51%)`	⬇️
server/server.go	`71.58% <0.00%> (-1.07%)`	⬇️
server/cluster/cluster.go	`82.22% <0.00%> (-0.48%)`	⬇️
client/client.go	`71.82% <0.00%> (-0.14%)`	⬇️
server/config/persist_options.go	`92.30% <0.00%> (+0.76%)`	⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a82d232...bb89d4e. Read the comment docs.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2021-09-06T07:59:33Z

In response to a cherrypick label: new pull request created: #4081.

ti-chi-bot · 2021-09-06T08:00:12Z

In response to a cherrypick label: new pull request created: #4082.

ti-chi-bot · 2021-09-06T08:00:48Z

In response to a cherrypick label: new pull request created: #4083.

ti-chi-bot · 2021-09-06T08:01:23Z

In response to a cherrypick label: new pull request created: #4084.

…nds (#4078) (#4082) * checker: judging that the peer is down is no longer based on DownSeconds Signed-off-by: HunDunDM <hundundm@gmail.com> * address comment Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: HunDunDM <hundundm@gmail.com>

…nds (#4078) (#4081) * This is an automated cherry-pick of #4078 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * resolve conflict Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: 混沌DM <hundundm@gmail.com> Co-authored-by: nolouch <nolouch@gmail.com>

…nds (#4078) (#4083) * checker: judging that the peer is down is no longer based on DownSeconds Signed-off-by: HunDunDM <hundundm@gmail.com> * address comment Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: HunDunDM <hundundm@gmail.com>

…nds (tikv#4078) * checker: judging that the peer is down is no longer based on DownSeconds Signed-off-by: HunDunDM <hundundm@gmail.com> * address comment Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

…nds (#4078) (#4178) * checker: judging that the peer is down is no longer based on DownSeconds Signed-off-by: HunDunDM <hundundm@gmail.com> * address comment Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

…nds (#4078) (#4084) * checker: judging that the peer is down is no longer based on DownSeconds Signed-off-by: HunDunDM <hundundm@gmail.com> * address comment Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: HunDunDM <hundundm@gmail.com>

…nds (tikv#4078) * checker: judging that the peer is down is no longer based on DownSeconds Signed-off-by: HunDunDM <hundundm@gmail.com> * address comment Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

checker: judging that the peer is down is no longer based on DownSeconds

e76bc71

Signed-off-by: HunDunDM <hundundm@gmail.com>

HunDunDM added component/checker Checker logic. type/bugfix This PR fixes a bug. labels Sep 6, 2021

HunDunDM requested review from nolouch and bufferflies September 6, 2021 04:37

ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 6, 2021

lhy1024 approved these changes Sep 6, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 6, 2021

HunDunDM added 2 commits September 6, 2021 14:04

Merge branch 'master' into fix-down-peer

6854903

address comment

0fdb1e1

Signed-off-by: HunDunDM <hundundm@gmail.com>

nolouch approved these changes Sep 6, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 6, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2021

Merge branch 'master' into fix-down-peer

bb89d4e

ti-chi-bot merged commit 63abda9 into tikv:master Sep 6, 2021

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 6, 2021

This is an automated cherry-pick of tikv#4078

9ee1fbc

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

This was referenced Sep 6, 2021

checker: judging that the peer is down is no longer based on DownSeconds (#4078) #4081

Merged

checker: judging that the peer is down is no longer based on DownSeconds (#4078) #4082

Merged

ti-chi-bot mentioned this pull request Sep 6, 2021

checker: judging that the peer is down is no longer based on DownSeconds (#4078) #4083

Merged

ti-chi-bot mentioned this pull request Sep 6, 2021

checker: judging that the peer is down is no longer based on DownSeconds (#4078) #4084

Merged

HunDunDM deleted the fix-down-peer branch September 6, 2021 08:16

HunDunDM linked an issue Sep 9, 2021 that may be closed by this pull request

PD not schedules down peers #4027

Closed

HunDunDM mentioned this pull request Sep 9, 2021

PD not schedules down peers #4027

Closed

HunDunDM mentioned this pull request Sep 28, 2021

checker: judging that the peer is down is no longer based on DownSeconds (#4078) #4178

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

checker: judging that the peer is down is no longer based on DownSeconds #4078

checker: judging that the peer is down is no longer based on DownSeconds #4078

HunDunDM commented Sep 6, 2021 •

edited

Loading

ti-chi-bot commented Sep 6, 2021 •

edited

Loading

disksing commented Sep 6, 2021

nolouch commented Sep 6, 2021

ti-chi-bot commented Sep 6, 2021

ti-chi-bot commented Sep 6, 2021

nolouch commented Sep 6, 2021

ti-chi-bot commented Sep 6, 2021

ti-chi-bot commented Sep 6, 2021

HunDunDM commented Sep 6, 2021

nolouch commented Sep 6, 2021

codecov bot commented Sep 6, 2021 •

edited

Loading

ti-chi-bot commented Sep 6, 2021

ti-chi-bot commented Sep 6, 2021

ti-chi-bot commented Sep 6, 2021

ti-chi-bot commented Sep 6, 2021

checker: judging that the peer is down is no longer based on DownSeconds #4078

checker: judging that the peer is down is no longer based on DownSeconds #4078

Conversation

HunDunDM commented Sep 6, 2021 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Sep 6, 2021 • edited Loading

disksing commented Sep 6, 2021

nolouch commented Sep 6, 2021

ti-chi-bot commented Sep 6, 2021

ti-chi-bot commented Sep 6, 2021

nolouch commented Sep 6, 2021

ti-chi-bot commented Sep 6, 2021

ti-chi-bot commented Sep 6, 2021

HunDunDM commented Sep 6, 2021

nolouch commented Sep 6, 2021

codecov bot commented Sep 6, 2021 • edited Loading

Codecov Report

ti-chi-bot commented Sep 6, 2021

ti-chi-bot commented Sep 6, 2021

ti-chi-bot commented Sep 6, 2021

ti-chi-bot commented Sep 6, 2021

HunDunDM commented Sep 6, 2021 •

edited

Loading

ti-chi-bot commented Sep 6, 2021 •

edited

Loading

codecov bot commented Sep 6, 2021 •

edited

Loading