Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: replace move-hot-read-peer with move-hot-read-leader #3657

Merged
merged 4 commits into from
May 12, 2021

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented May 7, 2021

What problem does this PR solve?

close #3649

it can be reviewed after #3658

What is changed and how it works?

replace move-hot-read-peer with move-hot-read-leader

Check List

Tests

  • Unit test
  • Integration test

Release note

@lhy1024 lhy1024 added the component/scheduler Scheduler logic. label May 7, 2021
@lhy1024 lhy1024 requested review from Yisaer and rleungx May 7, 2021 10:22
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #3657 (86749ad) into master (1faef48) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 86749ad differs from pull request most recent head 7c7b62a. Consider uploading reports for the commit 7c7b62a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3657      +/-   ##
==========================================
- Coverage   74.78%   74.75%   -0.04%     
==========================================
  Files         245      245              
  Lines       24238    24248      +10     
==========================================
  Hits        18126    18126              
- Misses       4505     4513       +8     
- Partials     1607     1609       +2     
Flag Coverage Δ
unittests 74.75% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region.go 81.01% <100.00%> (+0.33%) ⬆️
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/tso/global_allocator.go 71.65% <0.00%> (-7.09%) ⬇️
server/region_syncer/client.go 78.19% <0.00%> (-4.52%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
server/election/leadership.go 87.05% <0.00%> (-2.36%) ⬇️
server/core/storage.go 67.68% <0.00%> (-0.77%) ⬇️
server/cluster/cluster.go 82.88% <0.00%> (-0.49%) ⬇️
server/grpc_service.go 47.62% <0.00%> (-0.46%) ⬇️
server/schedule/operator/step.go 67.44% <0.00%> (-0.34%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1faef48...7c7b62a. Read the comment docs.

Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 12, 2021
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think adding a new opType is better. But I'm ok with the current implementation.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 12, 2021
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
Copy link
Contributor Author

lhy1024 commented May 12, 2021

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ad4720a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 12, 2021
@ti-chi-bot
Copy link
Member

@lhy1024: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sonarcloud
Copy link

sonarcloud bot commented May 12, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.0% 7.0% Duplication

@JmPotato
Copy link
Member

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit e83ceb7 into tikv:master May 12, 2021
Yisaer pushed a commit to Yisaer/pd that referenced this pull request May 14, 2021
…ikv#3657)

* fix

Signed-off-by: lhy1024 <admin@liudos.us>

* address comment

Signed-off-by: lhy1024 <admin@liudos.us>

* address comment

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request May 14, 2021
* change

Signed-off-by: yisaer <disxiaofei@163.com>

* fix go.sum

Signed-off-by: yisaer <disxiaofei@163.com>

* add comment

Signed-off-by: yisaer <disxiaofei@163.com>

* remove todo

Signed-off-by: yisaer <disxiaofei@163.com>

* fix test

Signed-off-by: yisaer <disxiaofei@163.com>

* add test

Signed-off-by: yisaer <disxiaofei@163.com>

* address the comment

Signed-off-by: yisaer <disxiaofei@163.com>

* address the comment

Signed-off-by: yisaer <disxiaofei@163.com>

* fix race

Signed-off-by: yisaer <disxiaofei@163.com>

* fix test

Signed-off-by: yisaer <disxiaofei@163.com>

address the comment

Signed-off-by: yisaer <disxiaofei@163.com>

* fix race

Signed-off-by: yisaer <disxiaofei@163.com>

* *: close the response body when finished with it (#3666)

* Close the response body when finished with it

Signed-off-by: JmPotato <ghzpotato@gmail.com>

* Remove a duplicate body close

Signed-off-by: JmPotato <ghzpotato@gmail.com>

* Address the comment

Signed-off-by: JmPotato <ghzpotato@gmail.com>

* Close the body immediately if there is no read

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

* scheduler: replace `move-hot-read-peer` with `move-hot-read-leader` (#3657)

* fix

Signed-off-by: lhy1024 <admin@liudos.us>

* address comment

Signed-off-by: lhy1024 <admin@liudos.us>

* address comment

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

* *: clean up useless parameters (#3667)

* Clean up useless parameters

Signed-off-by: JmPotato <ghzpotato@gmail.com>

* Define some const variables

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

* dashboard: Update to TiDB Dashboard v2021.05.12.1 (#3670)

* Update to TiDB Dashboard v2021.04.16.1

Signed-off-by: Suhaha <jklopsdfw@gmail.com>

* Update to TiDB Dashboard v2021.05.12.1

Signed-off-by: Suhaha <jklopsdfw@gmail.com>

Co-authored-by: 混沌DM <hundundm@gmail.com>

* address the comment

Signed-off-by: yisaer <disxiaofei@163.com>

* address the comment

Signed-off-by: yisaer <disxiaofei@163.com>

* address the comment

Signed-off-by: yisaer <disxiaofei@163.com>

Co-authored-by: JmPotato <ghzpotato@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: lhy1024 <admin@liudos.us>
Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Suhaha <jklopsdfw@gmail.com>
Co-authored-by: 混沌DM <hundundm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/scheduler Scheduler logic. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move-hot-read-peer may not take effect successfully
6 participants