-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: replace move-hot-read-peer
with move-hot-read-leader
#3657
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3657 +/- ##
==========================================
- Coverage 74.78% 74.75% -0.04%
==========================================
Files 245 245
Lines 24238 24248 +10
==========================================
Hits 18126 18126
- Misses 4505 4513 +8
- Partials 1607 1609 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: lhy1024 <admin@liudos.us>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think adding a new opType is better. But I'm ok with the current implementation.
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
Signed-off-by: lhy1024 <admin@liudos.us>
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: ad4720a
|
@lhy1024: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
/run-all-tests |
…ikv#3657) * fix Signed-off-by: lhy1024 <admin@liudos.us> * address comment Signed-off-by: lhy1024 <admin@liudos.us> * address comment Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
* change Signed-off-by: yisaer <disxiaofei@163.com> * fix go.sum Signed-off-by: yisaer <disxiaofei@163.com> * add comment Signed-off-by: yisaer <disxiaofei@163.com> * remove todo Signed-off-by: yisaer <disxiaofei@163.com> * fix test Signed-off-by: yisaer <disxiaofei@163.com> * add test Signed-off-by: yisaer <disxiaofei@163.com> * address the comment Signed-off-by: yisaer <disxiaofei@163.com> * address the comment Signed-off-by: yisaer <disxiaofei@163.com> * fix race Signed-off-by: yisaer <disxiaofei@163.com> * fix test Signed-off-by: yisaer <disxiaofei@163.com> address the comment Signed-off-by: yisaer <disxiaofei@163.com> * fix race Signed-off-by: yisaer <disxiaofei@163.com> * *: close the response body when finished with it (#3666) * Close the response body when finished with it Signed-off-by: JmPotato <ghzpotato@gmail.com> * Remove a duplicate body close Signed-off-by: JmPotato <ghzpotato@gmail.com> * Address the comment Signed-off-by: JmPotato <ghzpotato@gmail.com> * Close the body immediately if there is no read Signed-off-by: JmPotato <ghzpotato@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * scheduler: replace `move-hot-read-peer` with `move-hot-read-leader` (#3657) * fix Signed-off-by: lhy1024 <admin@liudos.us> * address comment Signed-off-by: lhy1024 <admin@liudos.us> * address comment Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * *: clean up useless parameters (#3667) * Clean up useless parameters Signed-off-by: JmPotato <ghzpotato@gmail.com> * Define some const variables Signed-off-by: JmPotato <ghzpotato@gmail.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * dashboard: Update to TiDB Dashboard v2021.05.12.1 (#3670) * Update to TiDB Dashboard v2021.04.16.1 Signed-off-by: Suhaha <jklopsdfw@gmail.com> * Update to TiDB Dashboard v2021.05.12.1 Signed-off-by: Suhaha <jklopsdfw@gmail.com> Co-authored-by: 混沌DM <hundundm@gmail.com> * address the comment Signed-off-by: yisaer <disxiaofei@163.com> * address the comment Signed-off-by: yisaer <disxiaofei@163.com> * address the comment Signed-off-by: yisaer <disxiaofei@163.com> Co-authored-by: JmPotato <ghzpotato@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: lhy1024 <admin@liudos.us> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: Suhaha <jklopsdfw@gmail.com> Co-authored-by: 混沌DM <hundundm@gmail.com>
What problem does this PR solve?
close #3649
it can be reviewed after #3658
What is changed and how it works?
replace
move-hot-read-peer
withmove-hot-read-leader
Check List
Tests
Release note