Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: simplify pending influence #3658

Merged
merged 7 commits into from
May 11, 2021
Merged

scheduler: simplify pending influence #3658

merged 7 commits into from
May 11, 2021

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented May 7, 2021

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

For a region to have only one operator at a time, it is not necessary to use [opLen]pendingInfluence

What is changed and how it works?

replace [opLen]pendingInfluence with simple pending influence

Check List

Tests

  • Unit test

Release note

@lhy1024
simplify pending influence
c082363 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 lhy1024 added type/enhancement The issue or PR belongs to an enhancement. component/scheduler Scheduler logic. labels May 7, 2021
@lhy1024 lhy1024 requested review from Yisaer and rleungx May 7, 2021 10:31
@lhy1024 lhy1024 mentioned this pull request May 7, 2021
Merged
@lhy1024
fix test
913a54c 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
fix test
8a65adc 
Signed-off-by: lhy1024 <admin@liudos.us>
@codecov
Copy link

codecov bot commented May 7, 2021 •
edited
Loading

Codecov Report

Merging #3658 (d4f505f) into master (8e3564d) will decrease coverage by 0.05%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3658      +/-   ##
==========================================
- Coverage   74.75%   74.69%   -0.06%     
==========================================
  Files         245      245              
  Lines       24247    24237      -10     
==========================================
- Hits        18125    18104      -21     
- Misses       4513     4517       +4     
- Partials     1609     1616       +7
Flag Coverage Δ
unittests 74.69% <72.72%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region.go 80.67% <72.72%> (-0.31%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/schedule/region_scatterer.go 83.72% <0.00%> (-4.66%) ⬇️
server/tso/tso.go 72.41% <0.00%> (-1.15%) ⬇️
server/server.go 71.88% <0.00%> (-0.93%) ⬇️
server/grpc_service.go 47.17% <0.00%> (-0.91%) ⬇️
server/schedule/operator_controller.go 85.19% <0.00%> (-0.82%) ⬇️
server/core/storage.go 67.68% <0.00%> (-0.77%) ⬇️
server/cluster/cluster.go 82.88% <0.00%> (-0.49%) ⬇️
client/client.go 71.54% <0.00%> (-0.42%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e3564d...d4f505f. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 8, 2021
@lhy1024
address comment
0ecf0cf 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
address comment
bbf0b37 
Signed-off-by: lhy1024 <admin@liudos.us>
nolouch
nolouch approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 10, 2021
@lhy1024
Copy link
Contributor Author

lhy1024 commented May 11, 2021

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bbf0b37

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 11, 2021
@lhy1024
Copy link
Contributor Author

lhy1024 commented May 11, 2021

/run-all-tests

@sonarcloud
Copy link

sonarcloud bot commented May 11, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.0% 7.0% Duplication

@ti-chi-bot ti-chi-bot merged commit bf0e891 into tikv:master May 11, 2021
@nolouch nolouch mentioned this pull request Jul 13, 2021
Closed
28 tasks
@HunDunDM HunDunDM mentioned this pull request Aug 31, 2021
Merged
HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Sep 1, 2021
@HunDunDM
scheduler: simplify pending influence (tikv#3658)
eb2b5fc 
Signed-off-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot added a commit that referenced this pull request Sep 1, 2021
@ti-chi-bot @HunDunDM
scheduler: fix inaccurate statistics and config (#3949) (#3964)
b1adc27 
* scheduler: simplify pending influence (#3658)

Signed-off-by: HunDunDM <hundundm@gmail.com>

* schedulers: unify the use and GC of hot-region's pendings and regionPendings (#3921)

Signed-off-by: HunDunDM <hundundm@gmail.com>

* scheduler: remove the useless code in hot-region-scheduler (#3833)

Signed-off-by: HunDunDM <hundundm@gmail.com>

* scheduler: fix inaccurate statistics and config (#3949)

Signed-off-by: HunDunDM <hundundm@gmail.com>

* tiny fix

Signed-off-by: HunDunDM <hundundm@gmail.com>

* tiny fix

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
@HunDunDM HunDunDM mentioned this pull request Sep 8, 2021
Merged
HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Sep 8, 2021
@HunDunDM
scheduler: simplify pending influence (tikv#3658)
fdadb32 
Signed-off-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot added a commit that referenced this pull request Sep 9, 2021
@ti-chi-bot @HunDunDM
scheduler: fix inaccurate statistics and config (#3949) (#3966)
605dc23 
* scheduler: simplify pending influence (#3658)

Signed-off-by: HunDunDM <hundundm@gmail.com>

* schedulers: unify the use and GC of hot-region's pendings and regionPendings (#3921)

Signed-off-by: HunDunDM <hundundm@gmail.com>

* scheduler: remove the useless code in hot-region-scheduler (#3833)

Signed-off-by: HunDunDM <hundundm@gmail.com>

* scheduler: fix inaccurate statistics and config (#3949)

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx left review comments

@Yisaer Yisaer Yisaer approved these changes

@nolouch nolouch nolouch approved these changes

Assignees
No one assigned
Labels
component/scheduler Scheduler logic. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lhy1024 @ti-chi-bot @nolouch @Yisaer @rleungx