scheduler: remove the useless code in hot-region-scheduler #3833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est package Signed-off-by: HunDunDM <hundundm@gmail.com>
Signed-off-by: HunDunDM <hundundm@gmail.com>
Signed-off-by: HunDunDM <hundundm@gmail.com>
HunDunDM
added
component/scheduler
ti-chi-bot
added
the
release-note-none
Codecov Report
@@ Coverage Diff @@
## master #3833 +/- ##
==========================================
- Coverage 75.06% 75.04% -0.03%
==========================================
Files 246 246
Lines 24757 24740 -17
==========================================
- Hits 18583 18565 -18
- Misses 4541 4546 +5
+ Partials 1633 1629 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
lhy1024
approved these changes
Jul 5, 2021
|
/merge |
|
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: f8b28b4
|
ti-chi-bot
added
the
status/can-merge
bufferflies
pushed a commit
to bufferflies/pd
that referenced
this pull request
Jul 9, 2021
* scheduler: move part of the code of the hot-region-scheduler to the test package Signed-off-by: HunDunDM <hundundm@gmail.com> * scheduler: remove the useless code in hot-region-scheduler Signed-off-by: HunDunDM <hundundm@gmail.com> * scheduler: fix nil pointer warning Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
HunDunDM
added a commit
to HunDunDM/pd
that referenced
this pull request
Jul 28, 2021
* scheduler: move part of the code of the hot-region-scheduler to the test package Signed-off-by: HunDunDM <hundundm@gmail.com> * scheduler: remove the useless code in hot-region-scheduler Signed-off-by: HunDunDM <hundundm@gmail.com> * scheduler: fix nil pointer warning Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
HunDunDM
added a commit
to ti-chi-bot/pd
that referenced
this pull request
Sep 1, 2021
Signed-off-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot
added a commit
that referenced
this pull request
Sep 1, 2021
* scheduler: simplify pending influence (#3658) Signed-off-by: HunDunDM <hundundm@gmail.com> * schedulers: unify the use and GC of hot-region's pendings and regionPendings (#3921) Signed-off-by: HunDunDM <hundundm@gmail.com> * scheduler: remove the useless code in hot-region-scheduler (#3833) Signed-off-by: HunDunDM <hundundm@gmail.com> * scheduler: fix inaccurate statistics and config (#3949) Signed-off-by: HunDunDM <hundundm@gmail.com> * tiny fix Signed-off-by: HunDunDM <hundundm@gmail.com> * tiny fix Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: HunDunDM <hundundm@gmail.com>
HunDunDM
added a commit
to ti-chi-bot/pd
that referenced
this pull request
Sep 8, 2021
Signed-off-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot
added a commit
that referenced
this pull request
Sep 9, 2021
* scheduler: simplify pending influence (#3658) Signed-off-by: HunDunDM <hundundm@gmail.com> * schedulers: unify the use and GC of hot-region's pendings and regionPendings (#3921) Signed-off-by: HunDunDM <hundundm@gmail.com> * scheduler: remove the useless code in hot-region-scheduler (#3833) Signed-off-by: HunDunDM <hundundm@gmail.com> * scheduler: fix inaccurate statistics and config (#3949) Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: HunDunDM <hundundm@gmail.com>
HunDunDM
added a commit
to ti-chi-bot/pd
that referenced
this pull request
Sep 15, 2021
Signed-off-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot
added a commit
that referenced
this pull request
Sep 15, 2021
* scheduler: remove the useless code in hot-region-scheduler (#3833) Signed-off-by: HunDunDM <hundundm@gmail.com> * scheduler: fix inaccurate statistics and config (#3949) Signed-off-by: HunDunDM <hundundm@gmail.com> * tiny fix Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: HunDunDM <hundundm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release note