Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: not limit remove peer of the down store (#4097) #4113

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4097

What problem does this PR solve?

Close #4090.

What is changed and how it works?

This PR adds a flag in the remove peer step to let the store limit not work when the remove store is down.

Check List

Tests

  • Unit test

Release note

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 13, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved component/schedule Scheduling logic. type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick. labels Sep 13, 2021
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz fix conflict

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2021
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 22, 2021
@nolouch
Copy link
Contributor

nolouch commented Nov 24, 2021

/run-all-tests

close tikv#4090

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx force-pushed the cherry-pick-4097-to-release-4.0 branch from 9fe3052 to 25cc231 Compare November 24, 2021 08:48
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #4113 (e972e61) into release-4.0 (f11d191) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-4.0    #4113   +/-   ##
============================================
  Coverage        74.97%   74.97%           
============================================
  Files              211      211           
  Lines            20065    20073    +8     
============================================
+ Hits             15044    15050    +6     
- Misses            3694     3696    +2     
  Partials          1327     1327           
Flag Coverage Δ
unittests 74.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/checker/rule_checker.go 81.16% <ø> (ø)
server/schedule/checker_controller.go 75.00% <100.00%> (+0.71%) ⬆️
server/schedule/operator/builder.go 92.80% <100.00%> (+0.12%) ⬆️
server/schedule/operator/influence.go 85.71% <100.00%> (ø)
server/schedule/operator/step.go 62.41% <100.00%> (+0.54%) ⬆️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
pkg/etcdutil/etcdutil.go 77.94% <0.00%> (-2.95%) ⬇️
server/member/leader.go 63.76% <0.00%> (-2.76%) ⬇️
pkg/btree/btree.go 85.30% <0.00%> (-0.97%) ⬇️
server/server.go 73.94% <0.00%> (-0.49%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f11d191...e972e61. Read the comment docs.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 24, 2021
@nolouch
Copy link
Contributor

nolouch commented Nov 24, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: e972e61

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 24, 2021
@ti-chi-bot ti-chi-bot merged commit 08bd389 into tikv:release-4.0 Nov 24, 2021
@zhouqiang-cl zhouqiang-cl added this to the v4.0.16 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/schedule Scheduling logic. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants