-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schedule: not limit remove peer of the down store (#4097) #4113
schedule: not limit remove peer of the down store (#4097) #4113
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz fix conflict
884b4a7
to
7d18934
Compare
/run-all-tests |
ddb46b7
to
783302c
Compare
close tikv#4090 Signed-off-by: Ryan Leung <rleungx@gmail.com>
9fe3052
to
25cc231
Compare
Codecov Report
@@ Coverage Diff @@
## release-4.0 #4113 +/- ##
============================================
Coverage 74.97% 74.97%
============================================
Files 211 211
Lines 20065 20073 +8
============================================
+ Hits 15044 15050 +6
- Misses 3694 3696 +2
Partials 1327 1327
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: e972e61
|
This is an automated cherry-pick of #4097
What problem does this PR solve?
Close #4090.
What is changed and how it works?
This PR adds a flag in the remove peer step to let the store limit not work when the remove store is down.
Check List
Tests
Release note