-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schedule: not limit remove peer of the down store #4097
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #4097 +/- ##
==========================================
+ Coverage 74.46% 74.49% +0.02%
==========================================
Files 258 258
Lines 26314 26323 +9
==========================================
+ Hits 19595 19609 +14
Misses 4973 4973
+ Partials 1746 1741 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Ryan Leung <rleungx@gmail.com>
I will have no way to limit it? |
Signed-off-by: Ryan Leung <rleungx@gmail.com>
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 8408f4e
|
/run-unit-test |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #4113. |
In response to a cherrypick label: new pull request created: #4114. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #4115. |
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: HunDunDM <hundundm@gmail.com>
Signed-off-by: HunDunDM <hundundm@gmail.com>
What problem does this PR solve?
Close #4090.
What is changed and how it works?
This PR adds a flag in the remove peer step to let the store limit not work when the remove store is down.
Check List
Tests
Release note