Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: not limit remove peer of the down store #4097

Merged
merged 3 commits into from
Sep 13, 2021

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Sep 8, 2021

What problem does this PR solve?

Close #4090.

What is changed and how it works?

This PR adds a flag in the remove peer step to let the store limit not work when the remove store is down.

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 8, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 8, 2021
@rleungx rleungx added the component/schedule Scheduling logic. label Sep 8, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 8, 2021
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #4097 (8408f4e) into master (5b1896e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4097      +/-   ##
==========================================
+ Coverage   74.46%   74.49%   +0.02%     
==========================================
  Files         258      258              
  Lines       26314    26323       +9     
==========================================
+ Hits        19595    19609      +14     
  Misses       4973     4973              
+ Partials     1746     1741       -5     
Flag Coverage Δ
unittests 74.49% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/checker_controller.go 66.66% <100.00%> (+0.70%) ⬆️
server/schedule/operator/builder.go 88.10% <100.00%> (-0.29%) ⬇️
server/schedule/operator/step.go 69.40% <100.00%> (+1.96%) ⬆️
server/schedule/placement/label_constraint.go 86.36% <0.00%> (-9.10%) ⬇️
server/kv/etcd_kv.go 72.46% <0.00%> (-7.25%) ⬇️
server/tso/local_allocator.go 71.62% <0.00%> (-6.76%) ⬇️
server/election/lease.go 84.12% <0.00%> (-4.77%) ⬇️
server/encryptionkm/key_manager.go 71.78% <0.00%> (-1.66%) ⬇️
server/tso/allocator_manager.go 67.16% <0.00%> (-1.17%) ⬇️
pkg/btree/btree.go 85.78% <0.00%> (-0.97%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b1896e...8408f4e. Read the comment docs.

@nolouch nolouch added needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 labels Sep 8, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 8, 2021
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@HunDunDM
Copy link
Member

HunDunDM commented Sep 9, 2021

I will have no way to limit it?

@nolouch nolouch added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2021
@rleungx
Copy link
Member Author

rleungx commented Sep 10, 2021

@HunDunDM @nolouch PTAL

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@nolouch nolouch removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 labels Sep 13, 2021
@nolouch
Copy link
Contributor

nolouch commented Sep 13, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8408f4e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 13, 2021
@nolouch
Copy link
Contributor

nolouch commented Sep 13, 2021

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 1a7caa9 into tikv:master Sep 13, 2021
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 13, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4113.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4114.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 13, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 13, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4115.

rleungx added a commit to rleungx/pd that referenced this pull request Sep 15, 2021
Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot added a commit that referenced this pull request Sep 15, 2021
Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
HunDunDM added a commit to HunDunDM/pd that referenced this pull request Oct 14, 2021
Signed-off-by: HunDunDM <hundundm@gmail.com>
HunDunDM added a commit to HunDunDM/pd that referenced this pull request Oct 18, 2021
Signed-off-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot pushed a commit that referenced this pull request Oct 18, 2021
* schedule: not limit remove peer of the down store (#4097)

Signed-off-by: HunDunDM <hundundm@gmail.com>

* schedule: correctly calculate the remove cost of the down peer (#4213)

Signed-off-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot added a commit that referenced this pull request Nov 24, 2021
* This is an automated cherry-pick of #4097

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* resolve the conflicts

close #4090

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot added a commit that referenced this pull request Nov 30, 2021
* This is an automated cherry-pick of #4097

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* resolve conflicts

close #4090

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/schedule Scheduling logic. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduling is not restricted by store limit when repairing down-peer
5 participants