schedule: correctly calculate the remove cost of the down peer

[HunDunDM]

Signed-off-by: HunDunDM hundundm@gmail.com

What problem does this PR solve?

What is changed and how it works?

schedule: correctly calculate the remove cost of the down peer

Check List

Tests

• Unit test

Code changes

Side effects

Related changes

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• disksing
• rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Merging #4213 (3ea2f60) into master (2230560) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4213      +/-   ##
==========================================
- Coverage   74.73%   74.67%   -0.07%     
==========================================
  Files         260      260              
  Lines       26690    26689       -1     
==========================================
- Hits        19947    19929      -18     
- Misses       4950     4971      +21     
+ Partials     1793     1789       -4     

Flag	Coverage Δ
unittests	74.67% <100.00%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/schedule/operator/influence.go	85.71% <100.00%> (ø)
server/schedule/operator/step.go	72.32% <100.00%> (-0.11%)	⬇️
server/schedulers/shuffle_hot_region.go	55.55% <0.00%> (-10.11%)	⬇️
server/id/id.go	76.19% <0.00%> (-4.77%)	⬇️
server/election/leadership.go	75.25% <0.00%> (-3.10%)	⬇️
server/schedule/operator_controller.go	82.68% <0.00%> (-1.23%)	⬇️
server/tso/tso.go	63.06% <0.00%> (-1.14%)	⬇️
server/server.go	70.95% <0.00%> (-0.90%)	⬇️
server/tso/allocator_manager.go	64.83% <0.00%> (-0.50%)	⬇️
client/client.go	72.50% <0.00%> (-0.14%)	⬇️
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2230560...3ea2f60. Read the comment docs.

[disksing]

/merge

[ti-chi-bot]

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 5d16bd0

[ti-chi-bot]

@HunDunDM: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.