Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TiDB Dashboard to v2021.11.08.1 [master] #4297

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Nov 7, 2021

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 7, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-commit-message release-note-none Denotes a PR that doesn't merit a release note. labels Nov 7, 2021
@github-actions github-actions bot added component/visualization Visualization. require-LGT1 Indicates that the PR requires an LGTM. labels Nov 7, 2021
@baurine
Copy link
Contributor Author

baurine commented Nov 7, 2021

This PR includes the new wordings for continuous profiling.

@baurine
Copy link
Contributor Author

baurine commented Nov 7, 2021

/cherry-pick release-5.3

@ti-chi-bot
Copy link
Member

@baurine: once the present PR merges, I will cherry-pick it on top of release-5.3 in the new PR and assign it to you.

In response to this:

/cherry-pick release-5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@crazycs520: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov
Copy link

codecov bot commented Nov 7, 2021

Codecov Report

Merging #4297 (e90e255) into master (1d56091) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4297      +/-   ##
==========================================
- Coverage   74.98%   74.96%   -0.03%     
==========================================
  Files         264      264              
  Lines       27255    27255              
==========================================
- Hits        20437    20431       -6     
- Misses       5009     5012       +3     
- Partials     1809     1812       +3     
Flag Coverage Δ
unittests 74.96% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/tso/local_allocator.go 64.86% <0.00%> (-13.52%) ⬇️
server/election/leadership.go 75.25% <0.00%> (-2.07%) ⬇️
server/tso/allocator_manager.go 65.66% <0.00%> (-1.50%) ⬇️
server/core/hot_region_storage.go 77.33% <0.00%> (-1.34%) ⬇️
server/member/member.go 64.70% <0.00%> (-0.54%) ⬇️
server/server.go 71.25% <0.00%> (-0.45%) ⬇️
server/id/id.go 80.95% <0.00%> (ø)
client/client.go 72.13% <0.00%> (+0.11%) ⬆️
server/grpc_service.go 51.31% <0.00%> (+0.60%) ⬆️
pkg/etcdutil/etcdutil.go 85.88% <0.00%> (+1.17%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d56091...e90e255. Read the comment docs.

close tikv#4257

Signed-off-by: baurine <2008.hbl@gmail.com>
@baurine baurine force-pushed the update-tidb-dashboard branch from 1851da0 to e90e255 Compare November 8, 2021 01:51
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 8, 2021
@HunDunDM
Copy link
Member

HunDunDM commented Nov 8, 2021

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e90e255

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 8, 2021
@ti-chi-bot ti-chi-bot merged commit 32b9337 into tikv:master Nov 8, 2021
@ti-chi-bot
Copy link
Member

@baurine: new pull request created: #4301.

In response to this:

/cherry-pick release-5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@baurine baurine deleted the update-tidb-dashboard branch November 8, 2021 03:26
hzh0425 pushed a commit to hzh0425/pd that referenced this pull request Nov 16, 2021
close tikv#4257

Signed-off-by: baurine <2008.hbl@gmail.com>
Signed-off-by: hzh0425 <642256541@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/visualization Visualization. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants