Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TiDB Dashboard to v2021.11.08.1 [release-5.3] #4299

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Nov 8, 2021

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 8, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@github-actions github-actions bot added component/visualization Visualization. require-LGT1 Indicates that the PR requires an LGTM. labels Nov 8, 2021
@baurine
Copy link
Contributor Author

baurine commented Nov 8, 2021

This is a cherry-pick for PR #4297

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #4299 (85f0617) into release-5.3 (6b3457e) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.3    #4299      +/-   ##
===============================================
+ Coverage        74.85%   74.97%   +0.11%     
===============================================
  Files              264      264              
  Lines            27250    27250              
===============================================
+ Hits             20398    20430      +32     
+ Misses            5036     5015      -21     
+ Partials          1816     1805      -11     
Flag Coverage Δ
unittests 74.97% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/region_syncer/server.go 83.08% <0.00%> (-5.89%) ⬇️
server/core/hot_region_storage.go 77.33% <0.00%> (-1.34%) ⬇️
server/grpc_service.go 50.20% <0.00%> (-1.32%) ⬇️
client/base_client.go 79.89% <0.00%> (-0.52%) ⬇️
client/client.go 71.79% <0.00%> (-0.24%) ⬇️
server/tso/allocator_manager.go 64.83% <0.00%> (+0.16%) ⬆️
server/server.go 72.45% <0.00%> (+0.29%) ⬆️
server/cluster/cluster.go 83.00% <0.00%> (+0.46%) ⬆️
server/core/storage.go 69.54% <0.00%> (+0.75%) ⬆️
server/config/persist_options.go 92.42% <0.00%> (+0.75%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b3457e...85f0617. Read the comment docs.

close tikv#4300

Signed-off-by: baurine <2008.hbl@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 8, 2021
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@crazycs520: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@nolouch
Copy link
Contributor

nolouch commented Nov 8, 2021

/run-unit-tests

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 8, 2021
@nolouch
Copy link
Contributor

nolouch commented Nov 8, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 85f0617

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 8, 2021
@HunDunDM HunDunDM added the type/cherry-pick-for-release-5.3 The PR belongs to release-5.3 cherry pick. label Nov 8, 2021
@ti-chi-bot ti-chi-bot merged commit a2d6504 into tikv:release-5.3 Nov 8, 2021
@baurine baurine deleted the update-tidb-dashboard-for-5.3 branch November 8, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/visualization Visualization. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-5.3 The PR belongs to release-5.3 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants