Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: check if GetStore returns nil #4347

Merged
merged 8 commits into from
Nov 24, 2021
Merged

*: check if GetStore returns nil #4347

merged 8 commits into from
Nov 24, 2021

Conversation

disksing
Copy link
Contributor

close #4344

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

If we use remove tombstone, GetStore may return nil. We should check it.

What is changed and how it works?

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

Fix panic issue after TiKV node scales in

@disksing
*: check if GetStore returns nil
a3e2377 
close tikv#4344

Signed-off-by: disksing <i@disksing.com>
@disksing disksing added type/bugfix This PR fixes a bug. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 labels Nov 18, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 18, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 18, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 18, 2021
@JmPotato
Copy link
Member

Wait for adding a test to merge.

@disksing disksing added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2021
@disksing
add test
9a401e5 
Signed-off-by: disksing <i@disksing.com>
@disksing disksing removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2021
@JmPotato
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 19, 2021
@JmPotato
Copy link
Member

/run-unit-test

4 similar comments
@JmPotato
Copy link
Member

/run-unit-test

@JmPotato
Copy link
Member

/run-unit-test

@nolouch
Copy link
Contributor

nolouch commented Nov 19, 2021

/run-unit-test

@nolouch
Copy link
Contributor

nolouch commented Nov 22, 2021

/run-unit-test

@nolouch
Copy link
Contributor

nolouch commented Nov 23, 2021

/run-unit-tests

@JmPotato
Copy link
Member

/run-unit-test

3 similar comments
@JmPotato
Copy link
Member

/run-unit-test

@disksing
Copy link
Contributor Author

/run-unit-test

@JmPotato
Copy link
Member

/run-unit-test

@JmPotato
Copy link
Member

/run-unit-tests

@ti-chi-bot ti-chi-bot merged commit 63c46a1 into tikv:master Nov 24, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4378.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 24, 2021
@disksing @ti-chi-bot
This is an automated cherry-pick of tikv#4347
df54757 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 24, 2021
Merged
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 24, 2021
@disksing @ti-chi-bot
This is an automated cherry-pick of tikv#4347
385a6ee 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 24, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4379.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 24, 2021
@disksing @ti-chi-bot
This is an automated cherry-pick of tikv#4347
dd9a2e2 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 24, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4380.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 24, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4381.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 24, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4382.

IcePigZDB pushed a commit to IcePigZDB/pd that referenced this pull request Nov 29, 2021
@disksing @ti-chi-bot @IcePigZDB
*: check if GetStore returns nil (tikv#4347)
f59fa9a 
* *: check if GetStore returns nil

close tikv#4344

Signed-off-by: disksing <i@disksing.com>

* add test

Signed-off-by: disksing <i@disksing.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Nov 30, 2021
@ti-chi-bot @disksing
*: check if GetStore returns nil (#4347) (#4382)
31ad343 
* *: check if GetStore returns nil

close #4344

Signed-off-by: disksing <i@disksing.com>

* add test

Signed-off-by: disksing <i@disksing.com>

Co-authored-by: disksing <i@disksing.com>
ti-chi-bot added a commit that referenced this pull request Nov 30, 2021
@ti-chi-bot @disksing
*: check if GetStore returns nil (#4347) (#4381)
e3a9ad4 
* *: check if GetStore returns nil

close #4344

Signed-off-by: disksing <i@disksing.com>

* add test

Signed-off-by: disksing <i@disksing.com>

Co-authored-by: disksing <i@disksing.com>
nolouch pushed a commit that referenced this pull request Nov 30, 2021
@ti-chi-bot
*: check if GetStore returns nil (#4347) (#4380)
c0fece4 
* This is an automated cherry-pick of #4347

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
disksing pushed a commit that referenced this pull request Nov 30, 2021
@ti-chi-bot
*: check if GetStore returns nil (#4347) (#4379)
fcecc89 
* This is an automated cherry-pick of #4347

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* resolve conflicts

Signed-off-by: disksing <i@disksing.com>
disksing pushed a commit that referenced this pull request Nov 30, 2021
@ti-chi-bot
*: check if GetStore returns nil (#4347) (#4378)
3a23716 
* This is an automated cherry-pick of #4347

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* fix conflicts

Signed-off-by: disksing <i@disksing.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@JmPotato JmPotato JmPotato approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PD panic after scale in TiKV node
6 participants
@disksing @ti-chi-bot @JmPotato @nolouch @lhy1024 @rleungx